feat: Views to cache discovered serializer

ref: #471 #511
nofusscomputing · Jan 31, 2025 · d86cc8a · d86cc8a
1 parent 49088f1
commit d86cc8a
Show file tree

Hide file tree

Showing 38 changed files with 429 additions and 80 deletions.
diff --git a/app/access/viewsets/organization.py b/app/access/viewsets/organization.py
@@ -75,13 +75,22 @@ class ViewSet( ModelViewSet ):
 
     def get_serializer_class(self):
 
+        if self.serializer_class:
+
+            return self.serializer_class
+
+
         if (
             self.action == 'list'
             or self.action == 'retrieve'
         ):
 
-            return globals()[str( self.model._meta.verbose_name) + 'ViewSerializer']
+            self.serializer_class = globals()[str( self.model._meta.verbose_name) + 'ViewSerializer']
+
+        else:
+
+            self.serializer_class = globals()[str( self.model._meta.verbose_name) + 'ModelSerializer']
 
 
-        return globals()[str( self.model._meta.verbose_name) + 'ModelSerializer']
+        return self.serializer_class
 
diff --git a/app/access/viewsets/team_user.py b/app/access/viewsets/team_user.py
@@ -184,15 +184,24 @@ def get_queryset(self):
 
     def get_serializer_class(self):
 
+        if self.serializer_class:
+
+            return self.serializer_class
+
+
         if (
             self.action == 'list'
             or self.action == 'retrieve'
         ):
 
-            return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ViewSerializer']
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ViewSerializer']
+
+        else:
+
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ModelSerializer']
 
 
-        return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ModelSerializer']
+        return self.serializer_class
 
 
     def get_return_url(self):

diff --git a/app/api/viewsets/common.py b/app/api/viewsets/common.py
@@ -561,6 +561,12 @@ class ModelViewSetBase(
     _Optional_, Used by API text search as the fields to search.
     """
 
+    serializer_class = None
+    """Serializer class to use,
+    
+    If not used, use get_serializer_class function and cache the class here.
+    """
+
 
     def get_queryset(self):
 
@@ -582,15 +588,24 @@ def get_queryset(self):
 
     def get_serializer_class(self):
 
+        if self.serializer_class:
+
+            return self.serializer_class
+
+
         if (
             self.action == 'list'
             or self.action == 'retrieve'
         ):
 
-            return globals()[str( self.model._meta.verbose_name) + 'ViewSerializer']
+            self.serializer_class = globals()[str( self.model._meta.verbose_name) + 'ViewSerializer']
+
+        else:
+
+            self.serializer_class = globals()[str( self.model._meta.verbose_name) + 'ModelSerializer']
 
 
-        return globals()[str( self.model._meta.verbose_name) + 'ModelSerializer']
+        return self.serializer_class
 
 
 

diff --git a/app/assistance/viewsets/knowledge_base.py b/app/assistance/viewsets/knowledge_base.py
@@ -82,13 +82,22 @@ class ViewSet( ModelViewSet ):
 
     def get_serializer_class(self):
 
+        if self.serializer_class:
+
+            return self.serializer_class
+
+
         if (
             self.action == 'list'
             or self.action == 'retrieve'
         ):
 
-            return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ViewSerializer']
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ViewSerializer']
+
+        else:
+
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ModelSerializer']
 
 
-        return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ModelSerializer']
+        return self.serializer_class
 
diff --git a/app/assistance/viewsets/model_knowledge_base_article.py b/app/assistance/viewsets/model_knowledge_base_article.py
@@ -138,15 +138,23 @@ def get_queryset(self):
 
     def get_serializer_class(self):
 
-        all_models = apps.get_models()
-
+        # all_models = apps.get_models()
+
+        if self.serializer_class:
+
+            return self.serializer_class
+
+
         if (
             self.action == 'list'
             or self.action == 'retrieve'
         ):
 
-            return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ViewSerializer']
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ViewSerializer']
+
+        else:
 
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ModelSerializer']
 
-        return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ModelSerializer']
 
+        return self.serializer_class
diff --git a/app/config_management/viewsets/config_group.py b/app/config_management/viewsets/config_group.py
@@ -94,13 +94,22 @@ def get_queryset(self):
 
     def get_serializer_class(self):
 
+        if self.serializer_class:
+
+            return self.serializer_class
+
+
         if (
             self.action == 'list'
             or self.action == 'retrieve'
         ):
 
-            return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ViewSerializer']
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ViewSerializer']
+
+        else:
+
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ModelSerializer']
 
 
-        return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ModelSerializer']
+        return self.serializer_class
 
diff --git a/app/config_management/viewsets/config_group_software.py b/app/config_management/viewsets/config_group_software.py
@@ -86,13 +86,22 @@ def get_queryset(self):
 
     def get_serializer_class(self):
 
+        if self.serializer_class:
+
+            return self.serializer_class
+
+
         if (
             self.action == 'list'
             or self.action == 'retrieve'
         ):
 
-            return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ViewSerializer']
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ViewSerializer']
+
+        else:
+
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ModelSerializer']
 
 
-        return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ModelSerializer']
+        return self.serializer_class
 
diff --git a/app/core/viewsets/manufacturer.py b/app/core/viewsets/manufacturer.py
@@ -73,12 +73,21 @@ class ViewSet(ModelViewSet):
 
     def get_serializer_class(self):
 
+        if self.serializer_class:
+
+            return self.serializer_class
+
+
         if (
             self.action == 'list'
             or self.action == 'retrieve'
         ):
 
-            return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ViewSerializer']
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ViewSerializer']
+
+        else:
+
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ModelSerializer']
 
 
-        return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ModelSerializer']
+        return self.serializer_class
diff --git a/app/core/viewsets/notes.py b/app/core/viewsets/notes.py
@@ -134,12 +134,21 @@ def get_view_name(self):
 
     def get_serializer_class(self):
 
+        if self.serializer_class:
+
+            return self.serializer_class
+
+
         if (
             self.action == 'list'
             or self.action == 'retrieve'
         ):
 
-            return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ViewSerializer']
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ViewSerializer']
+
+        else:
+
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ModelSerializer']
 
 
-        return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ModelSerializer']
+        return self.serializer_class
diff --git a/app/core/viewsets/related_ticket.py b/app/core/viewsets/related_ticket.py
@@ -89,15 +89,24 @@ class ViewSet(ModelListRetrieveDeleteViewSet):
 
     def get_serializer_class(self):
 
+        if self.serializer_class:
+
+            return self.serializer_class
+
+
         if (
             self.action == 'list'
             or self.action == 'retrieve'
         ):
 
-            return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ViewSerializer']
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ViewSerializer']
+
+        else:
+
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ModelSerializer']
 
 
-        return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ModelSerializer']
+        return self.serializer_class
 
 
     def get_queryset(self):

diff --git a/app/core/viewsets/ticket.py b/app/core/viewsets/ticket.py
@@ -245,6 +245,10 @@ def get_serializer_class(self):
 
         serializer_prefix = str(self._ticket_type).replace(' ', '')
 
+        if self.serializer_class:
+
+            return self.serializer_class
+
 
         if (
             self.action == 'create'
@@ -333,7 +337,13 @@ def get_serializer_class(self):
             or self.action == 'retrieve'
         ):
 
-            return globals()[serializer_prefix + 'TicketViewSerializer']
+            self.serializer_class = globals()[serializer_prefix + 'TicketViewSerializer']
+
+        else:
+            self.serializer_class = globals()[serializer_prefix + 'TicketModelSerializer']
+            self.serializer_class = globals()[serializer_prefix + 'TicketModelSerializer']
+
+        return self.serializer_class
 
 
-        return globals()[serializer_prefix + 'TicketModelSerializer']
+        return self.serializer_class
diff --git a/app/core/viewsets/ticket_category.py b/app/core/viewsets/ticket_category.py
@@ -73,12 +73,21 @@ class ViewSet(ModelViewSet):
 
     def get_serializer_class(self):
 
+        if self.serializer_class:
+
+            return self.serializer_class
+
+
         if (
             self.action == 'list'
             or self.action == 'retrieve'
         ):
 
-            return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ViewSerializer']
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ViewSerializer']
+
+        else:
+
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ModelSerializer']
 
 
-        return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ModelSerializer']
+        return self.serializer_class
diff --git a/app/core/viewsets/ticket_comment.py b/app/core/viewsets/ticket_comment.py
@@ -212,6 +212,10 @@ def get_queryset(self):
 
     def get_serializer_class(self):
 
+        if self.serializer_class:
+
+            return self.serializer_class
+
         organization:int = None
 
         serializer_prefix:str = 'TicketComment'
@@ -335,10 +339,14 @@ def get_serializer_class(self):
             or self.action == 'retrieve'
         ):
 
-            return globals()['TicketCommentViewSerializer']
+            self.serializer_class = globals()['TicketCommentViewSerializer']
 
 
-        return globals()[str(serializer_prefix).replace(' ', '') + 'ModelSerializer']
+        else:
+
+            self.serializer_class = globals()[str(serializer_prefix).replace(' ', '') + 'ModelSerializer']
+
+        return self.serializer_class
 
 
 

diff --git a/app/core/viewsets/ticket_comment_category.py b/app/core/viewsets/ticket_comment_category.py
@@ -69,12 +69,21 @@ class ViewSet(ModelViewSet):
 
     def get_serializer_class(self):
 
+        if self.serializer_class:
+
+            return self.serializer_class
+
+
         if (
             self.action == 'list'
             or self.action == 'retrieve'
         ):
 
-            return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ViewSerializer']
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ViewSerializer']
+
+        else:
+
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ModelSerializer']
 
 
-        return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ModelSerializer']
+        return self.serializer_class
diff --git a/app/core/viewsets/ticket_linked_item.py b/app/core/viewsets/ticket_linked_item.py
@@ -200,15 +200,24 @@ def get_parent_model(self):
 
     def get_serializer_class(self):
 
+        if self.serializer_class:
+
+            return self.serializer_class
+
+
         if (
             self.action == 'list'
             or self.action == 'retrieve'
         ):
 
-            return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ViewSerializer']
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ViewSerializer']
+
+        else:
+
+            self.serializer_class = globals()[str( self.model._meta.verbose_name).replace(' ' , '') + 'ModelSerializer']
 
 
-        return globals()[str( self.model._meta.verbose_name).replace(' ', '') + 'ModelSerializer']
+        return self.serializer_class