agents: refactor profiling on ZmqAgent #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3cf9f96 to
7e93975
Compare
trevnorris
approved these changes
Feb 26, 2024
7e93975 to
0266028
Compare
In preparation of adding support for heap profiling and sampling, extract the CPU Profiling logic into a 2 generic templated functions: `start_prof()` and `got_prof()` which can be configured via specific policies. Create the `CPUProfilePolicy` for now. Later on we will add policies for heap profiling and sampling. Encapsulate the state of every profile type into a `ProfileState`. PR-URL: #90 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
0266028 to
5dd46b2
Compare
trevnorris
pushed a commit
that referenced
this pull request
Feb 28, 2024
In preparation of adding support for heap profiling and sampling, extract the CPU Profiling logic into a 2 generic templated functions: `start_prof()` and `got_prof()` which can be configured via specific policies. Create the `CPUProfilePolicy` for now. Later on we will add policies for heap profiling and sampling. Encapsulate the state of every profile type into a `ProfileState`. PR-URL: #90 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of adding support for heap profiling and sampling, extract the CPU Profiling logic into a 2 generic templated functions:
start_prof()andgot_prof()which can be configured via specific policies. Create theCPUProfilePolicyfor now. Later on we will add policies for heap profiling and sampling.Encapsulate the state of every profile type into a
ProfileState.