Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add release automation #103

Merged
merged 4 commits into from
Feb 6, 2025
Merged

chore: Add release automation #103

merged 4 commits into from
Feb 6, 2025

Conversation

timfish
Copy link
Contributor

@timfish timfish commented Jan 30, 2025 •
edited
Loading

@timfish timfish marked this pull request as ready for review January 31, 2025 08:59
@timfish timfish requested review from trentm and legendecas February 3, 2025 14:34
@timfish timfish mentioned this pull request Feb 3, 2025
Merged
jsumners-nr
jsumners-nr requested changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR should focus on CI only. The other files should be added as a resolution to #102.

@timfish timfish changed the title chore: Add governance, CoC and release config chore: Add release automation Feb 3, 2025
@timfish timfish requested a review from jsumners-nr February 3, 2025 14:52
@legendecas
Copy link
Member

@trentm would you mind adding https://www.npmjs.com/~nodejs-foundation as a collaborator of the package https://www.npmjs.com/package/require-in-the-middle? I can help with the setup of the token after that.

@trentm
Copy link
Contributor

trentm commented Feb 4, 2025

Thanks. Was just looking at how to do this.

I've sent an invite to nodejs-foundation.

@trentm
Copy link
Contributor

trentm commented Feb 4, 2025

Screenshot 2025-02-03 at 4 03 26 PM

I assume I also need to change the "Publishing access" to the second option?

@trentm
Copy link
Contributor

trentm commented Feb 4, 2025

I assume I also need to change the "Publishing access" to the second option?

I have changed it to the second option.

@legendecas legendecas mentioned this pull request Feb 6, 2025
Merged
@legendecas
Copy link
Member

Created NPM_TOKEN and waiting for nodejs/admin#951

@timfish timfish merged commit 969b4f8 into nodejs:main Feb 6, 2025
15 checks passed
@timfish timfish deleted the chore/meta-and-release branch February 6, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentm trentm trentm approved these changes

@jsumners-nr jsumners-nr jsumners-nr approved these changes

@legendecas legendecas Awaiting requested review from legendecas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add release-please for auto release generation
4 participants
@timfish @legendecas @trentm @jsumners-nr