Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add require-in-the-middle release token #951

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Add require-in-the-middle release token #951

merged 2 commits into from
Feb 6, 2025
+11 −9

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Feb 6, 2025 •
edited
Loading

The requested token should have the following permissions:

permissions:
  contents: write
  pull-requests: write

Refs: nodejs/require-in-the-middle#103

@legendecas legendecas force-pushed the require-in-the-middle branch from d0c5705 to d157f37 Compare February 6, 2025 15:19
@legendecas legendecas mentioned this pull request Feb 6, 2025
Merged
mhdawson
mhdawson approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

mhdawson commented Feb 6, 2025

I believe I have added the token

@timfish
Copy link

timfish commented Feb 6, 2025 •
edited
Loading

Looks like it failed to create the release branch:
RequestError [HttpError]: Error creating Pull Request: Resource not accessible by personal access token
https://github.com/nodejs/require-in-the-middle/actions/runs/13188938824/job/36817662876#step:2:197

Was the NPM token added as a secret called RELEASE_PLEASE_GITHUB_TOKEN?
I guess the only thing is having the correct permissons?

@legendecas
Copy link
Member Author

I granted @nodejs-github-bot write access to the repo and the workflow is now working.

@legendecas legendecas merged commit 8ef2f39 into nodejs:main Feb 6, 2025
@legendecas legendecas deleted the require-in-the-middle branch February 6, 2025 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legendecas @mhdawson @timfish