-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Migrate message error tests from Python to JS #49738
Open
akhateeb22
wants to merge
3
commits into
nodejs:main
Choose a base branch
from
akhateeb22:actions/migrate-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
test/message/assert_throws_stack.js → test/fixtures/assert/assert_throws_stack.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
'use strict'; | ||
|
||
require('../common'); | ||
require('../../common'); | ||
const assert = require('assert').strict; | ||
|
||
assert.throws(() => { throw new Error('foo'); }, { bar: true }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
test/message/internal_assert.js → test/fixtures/assert/internal_assert.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
'use strict'; | ||
|
||
// Flags: --expose-internals | ||
require('../common'); | ||
require('../../common'); | ||
|
||
const assert = require('internal/assert'); | ||
assert(false); |
10 changes: 5 additions & 5 deletions
10
test/message/internal_assert.out → .../fixtures/assert/internal_assert.snapshot
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
test/message/internal_assert_fail.js → test/fixtures/assert/internal_assert_fail.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
'use strict'; | ||
|
||
// Flags: --expose-internals | ||
require('../common'); | ||
require('../../common'); | ||
|
||
const assert = require('internal/assert'); | ||
assert.fail('Unreachable!'); |
10 changes: 5 additions & 5 deletions
10
test/message/internal_assert_fail.out → ...ures/assert/internal_assert_fail.snapshot
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import '../common/index.mjs'; | ||
import * as fixtures from '../common/fixtures.mjs'; | ||
import * as snapshot from '../common/assertSnapshot.js'; | ||
import { describe, it } from 'node:test'; | ||
|
||
function replaceStackTrace(str) { | ||
return snapshot.replaceStackTrace(str, '$1at *$7\n'); | ||
} | ||
function normalize(str) { | ||
return str | ||
.replaceAll(snapshot.replaceWindowsPaths(process.cwd()), '') | ||
.replaceAll('/', '*') | ||
.replaceAll(process.version, '*') | ||
.replaceAll(/:\d+/g, '*'); | ||
} | ||
const common = snapshot | ||
.transform(snapshot.replaceWindowsLineEndings, snapshot.replaceWindowsPaths); | ||
|
||
const defaultTransform = snapshot.transform(common, replaceStackTrace, normalize); | ||
|
||
const tests = [ | ||
{ name: 'assert/assert_throws_stack.js' }, | ||
{ name: 'assert/internal_assert_fail.js' }, | ||
{ name: 'assert/internal_assert.js' }, | ||
]; | ||
|
||
describe('assertion output', { concurrency: true }, () => { | ||
for (const { name, transform } of tests) { | ||
it(name, async () => { | ||
await snapshot.spawnAndAssert(fixtures.path(name), transform ?? defaultTransform); | ||
}); | ||
} | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the test checking exactly for this stack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the test should check for it exactly ?, current test generates:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the original PR adding this test: #27243
@BridgeAR is this test intended to snapshot the entire stack trace? is this change ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea or suggestions to close this PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add another trasnform function to make this snapshot similar to the original one?