test: Migrate message error tests from Python to JS #49738
+53
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoLow
reviewed
Sep 20, 2023
|
@MoLow, Committed, Thank you |
MoLow
approved these changes
Sep 20, 2023
2a47489 to
6e8d588
Compare
|
@MoLow Hello, Thanks for reviewing, I committed some changes |
atlowChemi
reviewed
Sep 20, 2023
atlowChemi
reviewed
Sep 20, 2023
atlowChemi
reviewed
Sep 20, 2023
Comment on lines
-22
to
-25
| at assert.throws.bar (*assert_throws_stack.js:*) | ||
| at getActual (node:assert:*) | ||
| at Function.throws (node:assert:*) | ||
| at Object.<anonymous> (*assert_throws_stack.js:*:*) |
There was a problem hiding this comment.
Isn't the test checking exactly for this stack?
There was a problem hiding this comment.
the test should check for it exactly ?, current test generates:
at * {
generatedMessage: true,
code: 'ERR_ASSERTION',
actual: Error: foo
at *
at *
at *
at *
at *
at *
at *
at *
at *
at node:internal*main*run_main_module**,
expected: { bar: true },
operator: 'throws'
}
There was a problem hiding this comment.
Any idea or suggestions to close this PR ?
There was a problem hiding this comment.
maybe add another trasnform function to make this snapshot similar to the original one?
|
This needs a rebase to solve the git conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.