Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pty_helper.py doesn't work with python3 #29166

Closed
sam-github opened this issue Aug 16, 2019 · 1 comment
Closed

pty_helper.py doesn't work with python3 #29166

sam-github opened this issue Aug 16, 2019 · 1 comment
Labels
python PRs and issues that require attention from people who are familiar with Python.

Comments

@sam-github
Copy link
Contributor

In process of
#25789 this is seen:

make test PYTHON=python3

Path: pseudo-tty/test-tty-color-support
Traceback (most recent call last):
  File "/home/sam/w/core/lts/test/pseudo-tty/pty_helper.py", line 97, in <module>
    if pipe(parent_fd, STDOUT):
  File "/home/sam/w/core/lts/test/pseudo-tty/pty_helper.py", line 33, in pipe
    n = os.write(dfd, data)
TypeError: a bytes-like object is required, not 'filter'

Affects most(all?) pseudo-tty tests.

/cc @cclauss @bnoordhuis @nodejs/python

@sam-github sam-github added the python PRs and issues that require attention from people who are familiar with Python. label Aug 16, 2019
@cclauss
Copy link
Contributor

cclauss commented Aug 16, 2019

Python 2 does not distinguish between bytes and strings but Py3 strictly enforces it.

See to_utf8() Etc.

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Aug 16, 2019
@Trott Trott closed this as completed in 9c27118 Aug 19, 2019
targos pushed a commit that referenced this issue Aug 20, 2019
Fixes: #29166

PR-URL: #29167
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants