tools: make pty_helper.py python3-compatible

Fixes: nodejs#29166
bnoordhuis · Aug 16, 2019 · 08b2308 · 08b2308
1 parent 18405e6
commit 08b2308
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/test/pseudo-tty/pty_helper.py b/test/pseudo-tty/pty_helper.py
@@ -25,8 +25,12 @@ def pipe(sfd, dfd):
   if dfd == STDOUT:
     # Work around platform quirks. Some platforms echo ^D as \x04
     # (AIX, BSDs) and some don't (Linux).
-    filt = lambda c: ord(c) > 31 or c in '\t\n\r\f'
+    #
+    # The comparison against b' '[0] is because |data| is
+    # a string in python2 but a bytes object in python3.
+    filt = lambda c: c >= b' '[0] or c in b'\t\n\r\f'
     data = filter(filt, data)
+    data = bytes(data)
 
   while data:
     try: