-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build failure on Node 12.3.1 #1763
Comments
You need node-sass@4.12.0 for Node.js 12 support: https://github.com/sass/node-sass/releases/tag/v4.12.0 |
Do you install this globally? Because I added to my dependency/dev-dependency in package.json but I still get the same error :/ |
For me, the only way around this issue was to downgrade node.js version to 10. |
Same issue with node v13.5.0. Do I need to downgrade my node installation? |
node v12.16.1 also failed. Going to try with version 10 |
node v10.19.0 worked for me. |
Same issue with me, v12.x~13.x. |
Seeing this issue on node v13.5.0. |
Wow, why this issue is present for almost a year now and not addressed? |
@ar-international because we've been waiting for you to appear and show us the way! Seriously though, this is not a node-gyp problem, no need to continue commenting here as there's nothing we can do about it. Go and talk to node-sass about compatibility and figure out which version of Node is compatible with the version of node-sass you want to use, or the vice versa. |
node-sass says it's not their fault sass/node-sass#2794 |
had to downgrade to node 10 because of node-gyp issues nodejs/node-gyp#1763
|
This involved two fixes: - recreating the config on resume so that the end date is reset (`list.js`), and - setting "today" to the correct date when the datepicker is opened (`ionic-datepicker.bundle.min.js`) I have also added build instructions to my fork of the ionic-datepicker repo, but in case I delete the fork later, the instructions are: Install node 10.19.0 ([gulp-sass will fail for more recent version of node](nodejs/node-gyp#1763)) ``` node -v v10.19.0 ``` Install and check gulp version ``` npm install npm list | grep gulp ├─┬ gulp@3.9.0 ``` Build ``` npx gulp build ``` Testing done: Followed the steps in e-mission/e-mission-docs#531 (comment) Both end date and today are updated correctly
This involved two fixes: - recreating the config on resume so that the end date is reset (`list.js`), and - setting "today" to the correct date when the datepicker is opened (`ionic-datepicker.bundle.min.js`) I have also added build instructions to my fork of the ionic-datepicker repo, but in case I delete the fork later, the instructions are: Install node 10.19.0 ([gulp-sass will fail for more recent version of node](nodejs/node-gyp#1763)) ``` node -v v10.19.0 ``` Install and check gulp version ``` npm install npm list | grep gulp ├─┬ gulp@3.9.0 ``` Build ``` npx gulp build ``` Testing done: Followed the steps in e-mission/e-mission-docs#531 (comment) Both end date and today are updated correctly
This involved two fixes: - recreating the config on resume so that the end date is reset (`list.js`), and - setting "today" to the correct date when the datepicker is opened (`ionic-datepicker.bundle.min.js`) I have also added build instructions to my fork of the ionic-datepicker repo, but in case I delete the fork later, the instructions are: Install node 10.19.0 ([gulp-sass will fail for more recent version of node](nodejs/node-gyp#1763)) ``` node -v v10.19.0 ``` Install and check gulp version ``` npm install npm list | grep gulp ├─┬ gulp@3.9.0 ``` Build ``` npx gulp build ``` Testing done: Followed the steps in e-mission/e-mission-docs#531 (comment) Both end date and today are updated correctly
This involved two fixes: - recreating the config on resume so that the end date is reset (`list.js`), and - setting "today" to the correct date when the datepicker is opened (`ionic-datepicker.bundle.min.js`) I have also added build instructions to my fork of the ionic-datepicker repo, but in case I delete the fork later, the instructions are: Install node 10.19.0 ([gulp-sass will fail for more recent version of node](nodejs/node-gyp#1763)) ``` node -v v10.19.0 ``` Install and check gulp version ``` npm install npm list | grep gulp ├─┬ gulp@3.9.0 ``` Build ``` npx gulp build ``` Testing done: Followed the steps in e-mission/e-mission-docs#531 (comment) Both end date and today are updated correctly
This involved two fixes: - recreating the config on resume so that the end date is reset (`list.js`), and - setting "today" to the correct date when the datepicker is opened (`ionic-datepicker.bundle.min.js`) I have also added build instructions to my fork of the ionic-datepicker repo, but in case I delete the fork later, the instructions are: Install node 10.19.0 ([gulp-sass will fail for more recent version of node](nodejs/node-gyp#1763)) ``` node -v v10.19.0 ``` Install and check gulp version ``` npm install npm list | grep gulp ├─┬ gulp@3.9.0 ``` Build ``` npx gulp build ``` Testing done: Followed the steps in e-mission/e-mission-docs#531 (comment) Both end date and today are updated correctly
In v14.2.0, I was facing the same exact issue, the log errors were the same way. Steps for what I did: 1 - downgrade node to its current stable version, which corresponds to v12.16.3 at the moment; 2 - verified with 3 - then I tried @thaycacac's suggestion and after I ran 4 - so I ran 5 - finally I ran |
the problem is solved for me. |
re-installing node_modules/node-sass didn't not do the trick |
For me it was enough to install an older version of node-sass node -v npm -v |
worked for me (node v12.15.0) |
As some have commented here already, the fix for me was downgrading from node 12 to 10 latest release, which is 10.21.0 as of now, I did it using NVM which makes it so simple. |
@xzyfer @nschonni Can you please advise us on this closed issue? Above many users are suggesting installing node-sass requires downgrading their Node.js versions yet node-sass testing covers all current Node.js releases. |
Compatible versions are listed at the top of the readme https://github.com/sass/node-sass#supported-nodejs-versions-vary-by-release-please-consult-the-releases-page-below-is-a-quick-guide-for-minimum-support |
Thanks @iamforrest |
node v12.18.4 (stable) and still have the issue |
downgrading node to 10.22.1 did the trick:
|
Still having this issue on node 15 and 14 |
Which version of Node-saas? https://github.com/sass/node-sass#node-sass |
Uh, seems like I hurried to write the comment. The problem was in another package with old node-sass dependency (3.x). Sorry 👐 |
Yes. After trying everything, downgrade to node v10 only works. Thanks! |
I was working w/ an old project that used |
Instead of trying to downgrade node version I followed these steps: Give it a shot! It worked for me. |
I removed this package from package,json file ie "press": "^0.1.1" |
After spending hours I just downgraded the node v10. It worked for me. |
Target: x86_64-apple-darwin18.6.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
c++ '-DNODE_GYP_MODULE_NAME=binding' '-DUSING_UV_SHARED=1' '-DUSING_V8_SHARED=1' '-DV8_DEPRECATION_WARNINGS=1' '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D_DARWIN_USE_64_BIT_INODE=1' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-DOPENSSL_THREADS' '-DBUILDING_NODE_EXTENSION' -I/Users/robd/.node-gyp/12.3.1/include/node -I/Users/robd/.node-gyp/12.3.1/src -I/Users/robd/.node-gyp/12.3.1/deps/openssl/config -I/Users/robd/.node-gyp/12.3.1/deps/openssl/openssl/include -I/Users/robd/.node-gyp/12.3.1/deps/uv/include -I/Users/robd/.node-gyp/12.3.1/deps/zlib -I/Users/robd/.node-gyp/12.3.1/deps/v8/include -I../../nan -I../src/libsass/include -Os -gdwarf-2 -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -std=c++11 -MMD -MF ./Release/.deps/Release/obj.target/binding/src/create_string.o.d.raw -c -o Release/obj.target/binding/src/create_string.o ../src/create_string.cpp ../src/create_string.cpp:17:25: error: no matching constructor for initialization of 'v8::String::Utf8Value' v8::String::Utf8Value string(value); ^ ~~~~~ /Users/robd/.node-gyp/12.3.1/include/node/v8.h:3002:5: note: candidate constructor not viable: no known conversion from 'v8::Local' to 'const v8::String::Utf8Value' for 1st argument Utf8Value(const Utf8Value&) = delete; ^ /Users/robd/.node-gyp/12.3.1/include/node/v8.h:2995:5: note: candidate constructor not viable: requires 2 arguments, but 1 was provided Utf8Value(Isolate* isolate, Local obj); ^ 1 error generated. make: *** [Release/obj.target/binding/src/create_string.o] Error 1 gyp ERR! build error gyp ERR! stack Error: `make` failed with exit code: 2 gyp ERR! stack at ChildProcess.onExit (/Users/robd/code/voxsnap-v2/assets/node_modules/node-gyp/lib/build.js:262:23) gyp ERR! stack at ChildProcess.emit (events.js:200:13) gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12) gyp ERR! System Darwin 18.6.0 gyp ERR! command "/usr/local/Cellar/node/12.3.1/bin/node" "/Users/robd/code/voxsnap-v2/assets/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library=" gyp ERR! cwd /Users/robd/code/voxsnap-v2/assets/node_modules/node-sass gyp ERR! node -v v12.3.1 gyp ERR! node-gyp -v v3.8.0 gyp ERR! not ok Build failed with error code: 1
The text was updated successfully, but these errors were encountered: