Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

tools: add chakra_tdd.h to install.py #421

Closed
wants to merge 2 commits into from
Closed

tools: add chakra_tdd.h to install.py #421

wants to merge 2 commits into from

Conversation

joaocgreis
Copy link
Member

@joaocgreis joaocgreis commented Nov 2, 2017 •
edited
Loading

chakra_tdd.h was added to the sources in #397. This adds it to install.py to be included in the headers package.

Refs: #397
Fixes: #417

cc @mike-kaufman @mrkmarron

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

@joaocgreis
tools: add chakra_tdd.h to install.py
f3ae34a 
chakra_tdd.h was added to the sources. This adds it to install.py to
be included in the headers package.

Refs: nodejs#397
Fixes: nodejs#417
@joaocgreis
Copy link
Member Author

CI: https://ci.nodejs.org/view/All/job/chakracore-test-pull-request/156/
Test build: https://nodejs.org/download/test/v9.0.0-test20171101117809f8cc/

@joaocgreis joaocgreis mentioned this pull request Nov 2, 2017
Closed
gireeshpunathil
gireeshpunathil approved these changes Nov 2, 2017
View reviewed changes
Copy link
Member

@gireeshpunathil gireeshpunathil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about following the single line custom for single file inclusions? (for example L174 and L194)

@joaocgreis
Copy link
Member Author

Updated, single line sounds good for now.

joaocgreis added a commit that referenced this pull request Nov 9, 2017
@joaocgreis
tools: add chakra_tdd.h to install.py
fca1d9f 
chakra_tdd.h was added to the sources. This adds it to install.py to
be included in the headers package.

Refs: #397
Fixes: #417
PR-URL: #421
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Mike Kaufman <mike.kaufman@microsoft.com>
@joaocgreis
Copy link
Member Author

Landed in fca1d9f

@joaocgreis joaocgreis closed this Nov 9, 2017
kfarnung pushed a commit that referenced this pull request Jan 12, 2018
@joaocgreis @kfarnung
tools: add chakra_tdd.h to install.py
06f23df 
chakra_tdd.h was added to the sources. This adds it to install.py to
be included in the headers package.

Refs: #397
Fixes: #417
PR-URL: #421
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Mike Kaufman <mike.kaufman@microsoft.com>
chakrabot pushed a commit that referenced this pull request Mar 21, 2018
@jackhorton @chakrabot
deps: update ChakraCore to chakra-core/ChakraCore@adf0ecb899
3409177 
[MERGE #4832 @jackhorton] Update PlatformAgnostic case conversion functions to allow expanding-length strings

Merge pull request #4832 from jackhorton:icu/tocase

Fixes #421
Fixes #4526

Also fixes a previously untracked? bug where String.prototype.toLocale{Upper|Lower}Case.call(null) would print

Reviewed-By: chakrabot <chakrabot@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mike-kaufman mike-kaufman mike-kaufman approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[node-gyp] fatal error: 'chakra_ttd.h'
3 participants
@joaocgreis @gireeshpunathil @mike-kaufman