Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

[node-gyp] fatal error: 'chakra_ttd.h' #417

Closed
mrmlnc opened this issue Oct 14, 2017 · 3 comments
Closed

[node-gyp] fatal error: 'chakra_ttd.h' #417

mrmlnc opened this issue Oct 14, 2017 · 3 comments
Assignees
@mike-kaufman

Comments

@mrmlnc
Copy link

mrmlnc commented Oct 14, 2017 •
edited
Loading

  • Version: 8.6.0 (x64)
  • Platform: macOS (10.12.6)
  • Subsystem:

Source code: https://github.com/mrmlnc/scandir-native
Full Error:

> node-gyp configure build

  CXX(target) Release/obj.target/addon/src/cpp/addon.o
In file included from ../src/cpp/addon.cc:1:
In file included from ../node_modules/nan/nan.h:49:
/usr/local/nvs/chakracore/8.6.0/x64/include/node/node.h:99:10: fatal error: 'chakra_ttd.h'
      file not found
#include "chakra_ttd.h"
         ^~~~~~~~~~~~~~
1 error generated.
make: *** [Release/obj.target/addon/src/cpp/addon.o] Error 1

Works fine with 8.4.0, because v8.h has no #include "chakra_ttd.h". But also works fine with 8.6.0 on the Windows.
joaocgreis added a commit to joaocgreis/node-chakracore that referenced this issue Nov 2, 2017
@joaocgreis
tools: add chakra_tdd.h to install.py
f3ae34a 
chakra_tdd.h was added to the sources. This adds it to install.py to
be included in the headers package.

Refs: nodejs#397
Fixes: nodejs#417
@joaocgreis joaocgreis mentioned this issue Nov 2, 2017
Closed
4 tasks
@joaocgreis
Copy link
Member

Possible fix: #421

@joaocgreis
Copy link
Member

Fix landed, the next nightly should have it. Thanks for reporting @mrmlnc !

@mrmlnc
Copy link
Author

mrmlnc commented Nov 9, 2017

Thanks for your work 🌮

kfarnung pushed a commit that referenced this issue Jan 12, 2018
@joaocgreis @kfarnung
tools: add chakra_tdd.h to install.py
06f23df 
chakra_tdd.h was added to the sources. This adds it to install.py to
be included in the headers package.

Refs: #397
Fixes: #417
PR-URL: #421
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Mike Kaufman <mike.kaufman@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mike-kaufman mike-kaufman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: add chakra_tdd.h to install.py joaocgreis/node-chakracore
3 participants
@joaocgreis @mrmlnc @mike-kaufman