-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CONTRIBUTING.md including Yarn version update policy #393
Conversation
Oops, forgot about #382 which also adds a |
Actually I don't have permission to review here, but personally I prefer to get #382 merged first, unless it's still not acceptable and pending for updates. Otherwise, LGTM 👍 |
We can re-trigger CI, though that would probably be a waste of Travis' resources. I'm 👍 on merging w/o green CI since this is just a doc change. |
Yeah, I'm fine with merging this without a green CI. |
LGTM too |
Yarn 1.0 is released now. However, I don't see a reason to change our policy on this |
I also like our current policy (which is also very simple to implement in |
Yes I agree. |
There has been some confusion recently regarding when/how Yarn versions should be updated. I think we should agree on a specific strategy and document it somewhere. A
CONTRIBUTING.md
file seems like a good place for that, especially given that there is a broken link to it in ourREADME.md
😄The current proposal aims to ensure that a new Yarn release does not cause regressions in an already published SemVer-minor image tag. It's partially motivated by previous issues such as #386. It might be updated after Yarn 1.0 is released.
/cc @nodejs/docker @PeterDaveHello @Daniel15 @bestander for comments.