Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md including Yarn version update policy #393

Merged
merged 1 commit into from
Jun 4, 2017

Conversation

pesho
Copy link
Contributor

@pesho pesho commented May 3, 2017

There has been some confusion recently regarding when/how Yarn versions should be updated. I think we should agree on a specific strategy and document it somewhere. A CONTRIBUTING.md file seems like a good place for that, especially given that there is a broken link to it in our README.md 😄

The current proposal aims to ensure that a new Yarn release does not cause regressions in an already published SemVer-minor image tag. It's partially motivated by previous issues such as #386. It might be updated after Yarn 1.0 is released.

/cc @nodejs/docker @PeterDaveHello @Daniel15 @bestander for comments.

@pesho
Copy link
Contributor Author

pesho commented May 3, 2017

Oops, forgot about #382 which also adds a CONTRIBUTING.md file. One of the two PRs will have to be updated if the other is merged first.

@PeterDaveHello
Copy link
Member

Actually I don't have permission to review here, but personally I prefer to get #382 merged first, unless it's still not acceptable and pending for updates. Otherwise, LGTM 👍

@pesho pesho mentioned this pull request May 12, 2017
This was referenced May 29, 2017
Starefossen

This comment was marked as off-topic.

retrohacker

This comment was marked as off-topic.

@retrohacker
Copy link
Contributor

We can re-trigger CI, though that would probably be a waste of Travis' resources. I'm 👍 on merging w/o green CI since this is just a doc change.

@Starefossen
Copy link
Member

Yeah, I'm fine with merging this without a green CI.

@chorrell
Copy link
Contributor

chorrell commented Jun 4, 2017

LGTM too

@pesho pesho merged commit 67c9656 into nodejs:master Jun 4, 2017
@pesho pesho deleted the contributing-yarn branch June 4, 2017 11:05
@SimenB
Copy link
Member

SimenB commented Sep 7, 2017

Yarn 1.0 is released now. However, I don't see a reason to change our policy on this

https://code.facebook.com/posts/274518539716230

@pesho
Copy link
Contributor Author

pesho commented Sep 7, 2017

Yarn 1.0 is released now. However, I don't see a reason to change our policy on this

I also like our current policy (which is also very simple to implement in update.sh), but am open to better suggestions.

@chorrell
Copy link
Contributor

chorrell commented Sep 8, 2017

Yes I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants