Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predictable updates of yarn version #388

Closed
daveisfera opened this issue Apr 26, 2017 · 5 comments
Closed

Predictable updates of yarn version #388

daveisfera opened this issue Apr 26, 2017 · 5 comments
Labels

Comments

@daveisfera
Copy link

When the yarn version changes, it means that a new base image is generated. Can this be limited to a predictable schedule? I was thinking that update to the latest stable version of yarn when a new point release is made.

@razor-x
Copy link
Contributor

razor-x commented Apr 26, 2017

See also #386 (comment)

@Starefossen
Copy link
Member

Yarn will continued to be updated when Node.js version are updated. However, since Yarn is still experimental and has not reached a stable version (eg. 1.0) there may be breaking changes. Use on own risk.

@daveisfera
Copy link
Author

If this is really the stance being taken, then I believe that there should be a separate tag for the builds that include yarn. Having the image change every time yarn decides to do a release breaks the concept of fixed/reproducible builds in Docker.

@chorrell chorrell added the yarn label May 15, 2017
@nschonni
Copy link
Member

nschonni commented Jun 7, 2017

Think this is answered in the CONTRIBUTING.md now

Yarn is updated to the latest version only when there is a new Node.js SemVer-minor release, and it's updated only in the branch with the new release, preferably in the same PR. The update.sh script does this automatically when invoked with a specific branch, e.g. ./update.sh 6.10.

@pesho
Copy link
Contributor

pesho commented Jun 7, 2017

Yes, @nschonni is right. This was resolved in #393

@pesho pesho closed this as completed Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants