Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SP metadata: distinguish signing and encryption certs #255

Closed
wants to merge 1 commit into from

Conversation

benjamine
Copy link

@benjamine benjamine commented Jan 12, 2018

(see #150)
this PR attempts to make SP metadata distinguish between signing and encryption certs (they can be the same, or they can be different, or only of them can be specific).

here's an example with both being specified:

    <md:KeyDescriptor use="signing">
      <ds:KeyInfo xmlns:ds="http://www.w3.org/2000/09/xmldsig#">
        <ds:X509Data>
          <ds:X509Certificate>MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA1NbLn2Ao3cyAZ7SyfXif0gfctUML2Vjo9bovTyKF1Z/Ox9qj0lvqxIrKWJ3kPxSy2RXGFQvo7z/odPGMYkYQSQUdFEjVCBKzlT5DKu41NZaqHA9rHPHpLFMzqRkzCVFMPhvoZiVv9MyJ/3O3ZSFgGIjhQi8uxMRruNlwZ1HK5u10ALxEAyBJuhrUnXR6qeiKFYwmJfB5cu/svao5z7CWr2vQ8t9OiTywTz2cyIvzgNMtiqlc6017gy5zDWYyPoVGR6Gb+DyCmCq81VlHgmoDyaVpsPDKFFi4exJ/TiSeFVm/oXLl4Z5AkBdIA8z56T74xqOJjH5+L/ukbY8nZ6NrXQIDAQAB</ds:X509Certificate>
        </ds:X509Data>
      </ds:KeyInfo>
    </md:KeyDescriptor>
    <md:KeyDescriptor use="encryption">
      <ds:KeyInfo xmlns:ds="http://www.w3.org/2000/09/xmldsig#">
        <ds:X509Data>
          <ds:X509Certificate>MIIBIjCXBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA1NbLn2Ao3cyAZ7SyfXif0gfctUML2Vjo9bovTyKF1Z/Ox9qj0lvqxIrKWJ3kPxSy9RXGFQvo7z/odPGsYkYQSQUdFEjVCBKzlT5DKu41NZaqHA9rHPHpLFMzqRkzCVFMPhvoZiVv9MyJ/3O3ZSFgGIjhQi8uvMRruNlwZ1HK5u10ALxEAyBJuhrUnXR6qeiKFYwmJfB5cu/svao5z7CWr2vQ8t9OiTywTz2cyIvzgNMtiqlc6017gy5zDWYyPoVGR6Gb+DyCmCq81VlHgmoDyaVpsPDKFFi4exJ/TiSeFVm/oXLl4Z5AkBdIA8z56T74xqOJjH5+L/ukbY8nZ6NrXQIDAQAB</ds:X509Certificate>
        </ds:X509Data>
      </ds:KeyInfo>
    </md:KeyDescriptor>

(pending tests, and refs to SAML specs, but submitting to start getting feedback on the PR)

@benjamine
Copy link
Author

I'm realizing this is a very edgy case (using a single cert, for any of both usages, seems fine), at least for our needs.
I'll close this one for now.

@benjamine benjamine closed this Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants