Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include certificate in generated metadata #150

Closed
zxaos opened this issue Apr 5, 2016 · 2 comments
Closed

Include certificate in generated metadata #150

zxaos opened this issue Apr 5, 2016 · 2 comments

Comments

@zxaos
Copy link

zxaos commented Apr 5, 2016

If passport-saml is configured with a privateCert, the generated metadata does not include the corresponding public certificate.

It would be useful to either have another parameter we could pass to include the public certificate in the metadata, or if it would be added automatically if the privateCert file contained both the private key and the public cert.

@zxaos
Copy link
Author

zxaos commented Apr 12, 2016

For anyone else who comes across this issue - you can get the key to show up in the metadata by also configuring decryptionPvk and providing the certificate in the generateServiceProviderMetadata. It doesn't appear to be possible to only have the key present for signing, or to have different signing and decryption keys.

@benjamine
Copy link

@zxaos I'm making a first attempt to support separate signing and encription certs in metadata,
with pull #255

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants