Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Restore ants.legacy interfaces #3222

Merged
merged 3 commits into from
Jun 2, 2020

Conversation

effigies
Copy link
Member

@effigies effigies commented Jun 2, 2020

Summary

Fixes #3197.

List of changes proposed in this PR (pull-request)

I restored all three interfaces. I can limit it to antsIntroduction if preferred.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@satra
Copy link
Member

satra commented Jun 2, 2020

we could keep all three as long as ants distributes them. if they don't i think someone would have to maintain some form of deprecation/version-based interface. now that ants is versioning, this does become a little easier.

@effigies effigies added this to the 1.5.0 milestone Jun 2, 2020
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #3222 into master will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3222      +/-   ##
==========================================
- Coverage   65.00%   65.00%   -0.01%     
==========================================
  Files         301      302       +1     
  Lines       39836    39926      +90     
  Branches     5270     5279       +9     
==========================================
+ Hits        25896    25952      +56     
- Misses      12882    12914      +32     
- Partials     1058     1060       +2     
Flag Coverage Δ
#unittests 65.00% <66.66%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/ants/legacy.py 66.66% <66.66%> (ø)
nipype/pipeline/plugins/legacymultiproc.py 69.11% <0.00%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c48a18...81e8f9e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #3222 into master will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3222      +/-   ##
==========================================
- Coverage   65.00%   65.00%   -0.01%     
==========================================
  Files         301      302       +1     
  Lines       39836    39926      +90     
  Branches     5270     5279       +9     
==========================================
+ Hits        25896    25952      +56     
- Misses      12882    12914      +32     
- Partials     1058     1060       +2     
Flag Coverage Δ
#unittests 65.00% <66.66%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/ants/legacy.py 66.66% <66.66%> (ø)
nipype/pipeline/plugins/legacymultiproc.py 69.11% <0.00%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c48a18...81e8f9e. Read the comment docs.

@effigies effigies merged commit 1c84a70 into nipy:master Jun 2, 2020
@effigies effigies deleted the restore_ants_legacy branch June 2, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

antslegacy module
2 participants