Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

antslegacy module #3197

Closed
TheChymera opened this issue Mar 31, 2020 · 5 comments · Fixed by #3222
Closed

antslegacy module #3197

TheChymera opened this issue Mar 31, 2020 · 5 comments · Fixed by #3222

Comments

@TheChymera
Copy link
Collaborator

I notice that in the newest version the nipype.interfaces.ants.legacy module is missing, and I cannot find a class for antsIntroduction() anywhere in the package.

I know that using antsIntroduction is probably not the best idea, in fact I need it for an article recommending against it for preclinical imaging, but I need it for the benchmark. Is ti not coming back, and should I thus depend on older nipype for the article source code?

@oesteban
Copy link
Contributor

oesteban commented Apr 2, 2020

It seems to have been dropped here https://github.com/nipy/nipype/pull/2654/files#diff-a2e391882927e53f0bd8855c06af7009.

What's antsIntroduction for and, if its usage is not discouraged, maybe we should bring just that one back?

@TheChymera
Copy link
Collaborator Author

TheChymera commented Apr 2, 2020

@oesteban it's a mini-workflow by the ANTs team which is useful if you don't want to use an external preprocessing pipeline. I actually try to convince people not to use it with preclinical data, but with human data it can be quite useful given the numerous good heuristic presets they figured out: https://github.com/ANTsX/ANTs/blob/master/Scripts/antsIntroduction.sh

It would be really great if you can reinstate it.

@TheChymera
Copy link
Collaborator Author

@oesteban seeing as there's no action on this, can I just go ahead and bring it back? Will you pull?

@satra
Copy link
Member

satra commented May 10, 2020

@TheChymera - i can't remember why it was in the legacy module in the first place. perhaps @hjmjohnson does.

if there is no good reason for it to have been discarded, we should bring it back in some standard location, not legacy.

@oesteban
Copy link
Contributor

@TheChymera sure, I have no bandwidth to do it but I'd be happy to accept the PR. As Satra mentions, please do not restore the whole antslegacy module, just the interface you need somewhere more appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants