Added check to hide password in html reports

[dikwickley]

fixes: #3935
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

Final result
before:

after:

• Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
• If you're fixing a bug also create an issue if one doesn't exist yet;
• If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
• Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
• If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
• Do not include changes that are not related to the issue at hand;
• Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
• Always add unit tests - PRs without tests are most of the times ignored.

[dikwickley]

@garg3133 you can review this.

[github-actions]

Status

• ❌ No modified files found in the types directory.
  Please make sure to include types for any changes you have made. Thank you!.

[gravityvi]

Hey @dikwickley the changes look good. However can you think of a better way to hide it. Right now if you see the command in verbose logs it would show the passkey passed to setPassword command

[garg3133]

Right now if you see the command in verbose logs it would show the passkey passed to setPassword command

This would also appear in the "Raw HTTP log" tab of the report.

[garg3133]

We shouldn't add fix for a very specific case in a general method like this, it bloats these methods. We should always try to make our solution general so that we can easily expand it to other places as well (think if more commands were to use the redaction functionality, how the solution we're adding could help them as well without hard coding the command names).

See here how this functionality was approached earlier and try to make changes along the same lines and using the existing code: #2672

The above solution no longer works because while earlier we used to call TransportActions.post() to send HTTP requests directly, we now use Selenium methods (element.sendKeys() here) to do so.

[dikwickley]

Yes, I am looking into this only.

[garg3133]

Yeah sure, I just posted a message there so that other people can also try and find a solution to this, if they have no other issues to work on.

[garg3133]

Converted this to draft since it still requires work. Please feel free to mark it as ready for review when the PR is ready.