Feature/redact params #2672
Merged
Feature/redact params #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beatfactor
reviewed
May 22, 2021
| @@ -18,6 +18,10 @@ class TreeNode { | |||
| return this.__instance; | |||
| } | |||
|
|
|||
| get redact() { | |||
| return this.options ? this.options.redact || false : false; | |||
There was a problem hiding this comment.
why not simply say this.options && this.options.redact?
There was a problem hiding this comment.
that might return undefined, which works in this context but here it explicitly returns a boolean
There was a problem hiding this comment.
Not really, It returns something or false, and it's also a very confusing statement. And in any case, this.options is always going to be defined so you could say !!this.options.redact to always get a boolean. Or just this.options.redact is also fine.
There was a problem hiding this comment.
sure will check and modify it to make it more clear
beatfactor
reviewed
May 22, 2021
| @@ -204,6 +204,7 @@ class CommandLoader extends BaseCommandLoader { | |||
|
|
|||
| this.validateMethod(parent); | |||
|
|
|||
| const redact = this.module.RedactParams || false; | |||
There was a problem hiding this comment.
it takes a value from static getter from the command
There was a problem hiding this comment.
This was referenced Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.
features/my-new-featureorissue/123-my-bugfix);fixes #758