-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contextual links #1000 #1001 #1102
Changes from 16 commits
5776e5d
4e1a1ad
28f545c
fce0b39
fae5713
ebc5c50
b91e3e5
a8e9902
939913e
e98ecdd
652bfe6
9307850
4c348d6
28111bd
9c3f767
5eda722
a4d6a5e
42e5473
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,30 @@ | ||
<h2 class="nhsuk-u-padding-top-4">Have you{% if subSection === "Styles" %} tested these styles{% endif %}{% if subSection === "Components" %} tested this component{% endif %}{% if subSection === "Patterns" %} tested this pattern{% endif %}{% if pageSection === "Content style guide" %} used this guidance{% endif %}?</h2> | ||
<h2 class="nhsuk-u-padding-top-4">{% if subSection === "Styles" %}Have you tested these styles{% endif %}{% if subSection === "Components" %}Have you tested this component{% endif %}{% if subSection === "Patterns" %}Have you tested this pattern{% endif %}{% if pageSection === "Content style guide" or pageSection === "Accessibility" %}Would you like to contribute to this guidance{% endif %}{% if pageSection === "NHS service standard" %}Would you like to contribute to the NHS service standard{% endif %}?</h2> | ||
{% if subSection === "Styles" or subSection === "Components" or subSection === "Patterns" %} | ||
|
||
<p>If so, please share your research findings and let us know how it has worked for you. This will help us improve it for everyone.</p> | ||
<p>Before you start, you will need a <a href="https://github.com/join?source=login">GitHub account</a>. It's an open forum where we collect feedback.</p> | ||
{% endif %} | ||
{% if pageSection === "Content style guide" %} | ||
{% if pageSection === "Content style guide" or pageSection === "Accessibility" %} | ||
|
||
<p>Please let us know how this has worked for you and, in particular, if you have research findings to share. This will help us improve it for everyone.</p> | ||
<p>Before you start, you will need a <a href="https://github.com/join?source=login">GitHub account</a>. It's an open forum where we collect feedback.</p> | ||
{% endif %} | ||
|
||
{% if pageSection === "NHS service standard"%} | ||
<p>Please let us know how this has worked for you and, in particular, if you have gone through a GDS or NHSX service assessment or peer review. This will help us improve it for everyone.</p> | ||
<p>Before you start, you will need a <a href="https://github.com/join?source=login">GitHub account</a>. It's an open forum where we collect feedback.</p> | ||
{% endif %} | ||
|
||
<div class="nhsuk-action-link"> | ||
<a class="nhsuk-action-link__link" href="https://github.com/nhsuk/nhsuk-service-manual-backlog/issues/{{backlog_issue_id}}"> | ||
<svg class="nhsuk-icon nhsuk-icon__arrow-right-circle" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" aria-hidden="true"> | ||
<path d="M0 0h24v24H0z" fill="none"></path> | ||
<path d="M12 2a10 10 0 0 0-9.95 9h11.64L9.74 7.05a1 1 0 0 1 1.41-1.41l5.66 5.65a1 1 0 0 1 0 1.42l-5.66 5.65a1 1 0 0 1-1.41 0 1 1 0 0 1 0-1.41L13.69 13H2.05A10 10 0 1 0 12 2z"></path> | ||
</svg> | ||
<span class="nhsuk-action-link__text">Share your research findings on GitHub</span> | ||
<span class="nhsuk-action-link__text">Share your findings on GitHub</span> | ||
</a> | ||
</div> | ||
<p>If you have any questions, you can <a href="https://service-manual.nhs.uk/slack">message our community forum on Slack</a> or <a href="mailto:service-manual@nhs.net">contact us by email</a>. | ||
<p>If you have any questions, you can <a href="https://service-manual.nhs.uk/slack">message us on Slack</a>. You will need a Slack account if you do not have one. Or you can <a href="mailto:service-manual@nhs.net">contact us by email</a>. {% if pageTitle === "Getting started with accessibility" %} You can also <a href="https://www.gov.uk/service-manual/communities/accessibility-community">contact the GOV.UK accessibility community</a>.{% endif %} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @sarawilcox Added the partial style back in pending review with Leigh There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi Tosin, I think we need to take the mention of the GOV.UK community out of the partial. It's just part of the body content on the Getting started page. |
||
</p> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarawilcox - added the original section within the getting starting with accessibility page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Tosin, what about the text that follows? Is it still included?
I'd leave the text on the page as it is for now and drop the partial in underneath it. I can always change the text on the page if it doesn't work with the partial underneath.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarawilcox - This is intentional as that page is more about telling the user what it is and isn't primed for feedback. The theory for pages like this is that the 'get in touch' footer should work for those. Our main hypothesis focused on any page that goes into the 'how'. We also still have the hub partial to create which might serve this need