Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contextual links #1000 #1001 #1102

Merged
merged 18 commits into from
Apr 7, 2021
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# NHS digital service manual Changelog

## 3.14.3 - 30 March 2021
## 3.14.3 - 06 April 2021

:wrench: **Fixes**

Expand All @@ -9,6 +9,11 @@
- Fix context links within `content/how-to-write-good-questions-for-forms`
- Update all context links within `app/views/content`
- Update all context links within `app/views/design-system`
- Update all context links within `app/views/accessibility`
- Update all context links within `app/views/service-standard`
- Remove 'other help' contact section under 'guidance' on all service standard guidance pages `app/views/service-standard`
- Remove 'id="talk-to-other-people-with-an-interest-in-accessibility' in `app/views/accessibility/getting-started.njk`
- Remove ./partials/share-your-research.njk in `app/views/accessibility/user-research.njk`
- Find and replace all non-closing `<p>` tags - [Issue 1092](https://github.com/nhsuk/nhsuk-service-manual/issues/1092)


Expand Down
1 change: 1 addition & 0 deletions app/views/accessibility/content.njk
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
{% set pageDescription = "What content designers, writers and editors need to do to make digital services accessible." %}
{% set theme = "Accessibility guidance for:" %}
{% set dateUpdated = "November 2019" %}
{% set backlog_issue_id = "347" %}

{% extends "includes/app-layout.njk" %}

Expand Down
1 change: 1 addition & 0 deletions app/views/accessibility/design.njk
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
{% set pageDescription = "What graphic and interaction designers need to do to make digital services accessible." %}
{% set theme = "Accessibility guidance for:" %}
{% set dateUpdated = "July 2019" %}
{% set backlog_issue_id = "349" %}

{% extends "includes/app-layout.njk" %}

Expand Down
1 change: 1 addition & 0 deletions app/views/accessibility/development.njk
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
{% set pageDescription = "What developers need to do to make digital services accessible." %}
{% set theme = "Accessibility guidance for:" %}
{% set dateUpdated = "July 2019" %}
{% set backlog_issue_id = "348" %}

{% extends "includes/app-layout.njk" %}

Expand Down
2 changes: 2 additions & 0 deletions app/views/accessibility/getting-started.njk
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
{% set pageDescription = "Things you can do to learn about accessibility." %}
{% set theme = "Everyone needs to know" %}
{% set dateUpdated = "July 2019" %}
{% set backlog_issue_id = "352" %}

{% extends "includes/app-layout.njk" %}

Expand Down Expand Up @@ -49,6 +50,7 @@
<h2 id="talk-to-other-people-with-an-interest-in-accessibility">Talk to other people with an interest in accessibility</h2>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarawilcox - added the original section within the getting starting with accessibility page

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tosin, what about the text that follows? Is it still included?

Join the GOV.UK accessibility community or talk to NHS colleagues on our public Slack workspace to get advice and support, stay up to date and share examples.

I'd leave the text on the page as it is for now and drop the partial in underneath it. I can always change the text on the page if it doesn't work with the partial underneath.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tosin, there isn't a partial on the What all NHS services need to do about accessibility page. Do you have time to sort that out? If not, I'll ask @AdamChrimes if he can help tomorrow.

@sarawilcox - This is intentional as that page is more about telling the user what it is and isn't primed for feedback. The theory for pages like this is that the 'get in touch' footer should work for those. Our main hypothesis focused on any page that goes into the 'how'. We also still have the hub partial to create which might serve this need

<p>Join the <a href="https://www.gov.uk/service-manual/communities/accessibility-community">GOV.UK accessibility community</a> or talk to NHS colleagues on our <a href="/slack">public Slack workspace</a> to get advice and support, stay up to date and share examples.</p>


{% endblock %}

{% block asideContent %}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
{% set pageDescription = "Our approach to accessibility." %}
{% set theme = "Everyone needs to know" %}
{% set dateUpdated = "July 2019" %}
{% set backlog_issue_id = "351" %}

{% extends "includes/app-layout.njk" %}

Expand Down
1 change: 1 addition & 0 deletions app/views/accessibility/index.njk
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
{% set pageDescription = "How to make digital services in the NHS work for everyone." %}
{% set pageSection = "Accessibility" %}
{% set landingPage = true %}
{% set hideContact = "true" %}

{% extends "includes/app-layout.njk" %}

Expand Down
1 change: 1 addition & 0 deletions app/views/accessibility/product-and-delivery.njk
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
{% set pageDescription = "What product and delivery managers need to do to make digital services accessible." %}
{% set theme = "Accessibility guidance for:" %}
{% set dateUpdated = "March 2021" %}
{% set backlog_issue_id = "345" %}

{% extends "includes/app-layout.njk" %}

Expand Down
1 change: 1 addition & 0 deletions app/views/accessibility/testing.njk
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
{% set pageDescription = "What testers and quality assurers need to do to make digital services accessible." %}
{% set theme = "Accessibility guidance for:" %}
{% set dateUpdated = "November 2019" %}
{% set backlog_issue_id = "350" %}

{% extends "includes/app-layout.njk" %}

Expand Down
2 changes: 1 addition & 1 deletion app/views/accessibility/user-research.njk
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
{% set pageDescription = "What user researchers need to do to make digital services accessible." %}
{% set theme = "Accessibility guidance for:" %}
{% set dateUpdated = "July 2019" %}
{% set backlog_issue_id = "346" %}

{% extends "includes/app-layout.njk" %}

Expand All @@ -21,7 +22,6 @@
{% include "./partials/understand-participants-needs-before-you-test.njk" %}
{% include "./partials/make-your-research-more-accessible-on-the-day.njk" %}
{% include "./partials/look-after-your-team.njk" %}
{% include "./partials/share-your-research.njk" %}

{% endblock %}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
{% set pageDescription = "The NHS is for everyone, so NHS digital services should be accessible to everyone too." %}
{% set theme = "Everyone needs to know" %}
{% set dateUpdated = "July 2019" %}
{% set hideContact = "true" %}

{% extends "includes/app-layout.njk" %}

Expand Down
16 changes: 12 additions & 4 deletions app/views/includes/_contact-panel.njk
Original file line number Diff line number Diff line change
@@ -1,22 +1,30 @@
<h2 class="nhsuk-u-padding-top-4">Have you{% if subSection === "Styles" %} tested these styles{% endif %}{% if subSection === "Components" %} tested this component{% endif %}{% if subSection === "Patterns" %} tested this pattern{% endif %}{% if pageSection === "Content style guide" %} used this guidance{% endif %}?</h2>
<h2 class="nhsuk-u-padding-top-4">{% if subSection === "Styles" %}Have you tested these styles{% endif %}{% if subSection === "Components" %}Have you tested this component{% endif %}{% if subSection === "Patterns" %}Have you tested this pattern{% endif %}{% if pageSection === "Content style guide" or pageSection === "Accessibility" %}Would you like to contribute to this guidance{% endif %}{% if pageSection === "NHS service standard" %}Would you like to contribute to the NHS service standard{% endif %}?</h2>
{% if subSection === "Styles" or subSection === "Components" or subSection === "Patterns" %}

<p>If so, please share your research findings and let us know how it has worked for you. This will help us improve it for everyone.</p>
<p>Before you start, you will need a <a href="https://github.com/join?source=login">GitHub account</a>. It's an open forum where we collect feedback.</p>
{% endif %}
{% if pageSection === "Content style guide" %}
{% if pageSection === "Content style guide" or pageSection === "Accessibility" %}

<p>Please let us know how this has worked for you and, in particular, if you have research findings to share. This will help us improve it for everyone.</p>
<p>Before you start, you will need a <a href="https://github.com/join?source=login">GitHub account</a>. It's an open forum where we collect feedback.</p>
{% endif %}

{% if pageSection === "NHS service standard"%}
<p>Please let us know how this has worked for you and, in particular, if you have gone through a GDS or NHSX service assessment or peer review. This will help us improve it for everyone.</p>
<p>Before you start, you will need a <a href="https://github.com/join?source=login">GitHub account</a>. It's an open forum where we collect feedback.</p>
{% endif %}

<div class="nhsuk-action-link">
<a class="nhsuk-action-link__link" href="https://github.com/nhsuk/nhsuk-service-manual-backlog/issues/{{backlog_issue_id}}">
<svg class="nhsuk-icon nhsuk-icon__arrow-right-circle" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" aria-hidden="true">
<path d="M0 0h24v24H0z" fill="none"></path>
<path d="M12 2a10 10 0 0 0-9.95 9h11.64L9.74 7.05a1 1 0 0 1 1.41-1.41l5.66 5.65a1 1 0 0 1 0 1.42l-5.66 5.65a1 1 0 0 1-1.41 0 1 1 0 0 1 0-1.41L13.69 13H2.05A10 10 0 1 0 12 2z"></path>
</svg>
<span class="nhsuk-action-link__text">Share your research findings on GitHub</span>
<span class="nhsuk-action-link__text">Share your findings on GitHub</span>
</a>
</div>
<p>If you have any questions, you can <a href="https://service-manual.nhs.uk/slack">message our community forum on Slack</a> or <a href="mailto:service-manual@nhs.net">contact us by email</a>.
<p>If you have any questions, you can <a href="https://service-manual.nhs.uk/slack">message us on Slack</a>. You will need a Slack account if you do not have one. Or you can <a href="mailto:service-manual@nhs.net">contact us by email</a>. {% if pageTitle === "Getting started with accessibility" %} You can also <a href="https://www.gov.uk/service-manual/communities/accessibility-community">contact the GOV.UK accessibility community</a>.{% endif %}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarawilcox Added the partial style back in pending review with Leigh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tosin, I think we need to take the mention of the GOV.UK community out of the partial. It's just part of the body content on the Getting started page.

</p>

2 changes: 1 addition & 1 deletion app/views/includes/app-layout.njk
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@

{% block contactPanel %}
{% if hideContact != "true" %}
{% if subSection === "Styles" or subSection === "Components" or subSection === "Patterns" or pageSection === "Content style guide" %}
{% if subSection === "Styles" or subSection === "Components" or subSection === "Patterns" or pageSection === "Content style guide" or pageSection === "Accessibility" or pageSection === "NHS service standard" %}
{% include "./_contact-panel.njk" %}
{% endif %}
{% else %}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
{% set pageDescription = "Take time to understand your users' clinical, practical and emotional needs - and their abilities - and the problem you're trying to solve for them." %}
{% set beta = true %}
{% set dateUpdated = "December 2019" %}
{% set backlog_issue_id = "335" %}

{% extends "includes/app-layout.njk" %}

Expand Down Expand Up @@ -57,12 +58,11 @@
<li><a href="https://gds.blog.gov.uk/2018/01/10/working-with-citizens-advice-and-its-amazing-data/">Working with Citizens Advice and its amazing data</a> (GDS blog, 2018)</li>
</ul>

<h3>Other help</h3>
<ul>
<li>Talk to us on the <a href="/slack">service manual Slack channel</a> or email the standards team at <a href="mailto:service-manual@nhs.net">service-manual@nhs.net</a>.</li>
</ul>
{% endblock %}

{% block afterContact %}

{{ pagination({
{{ pagination({
"nextUrl": "/service-standard/2-and-3-work-towards-solving-a-whole-problem-and-provide-a-joined-up-experience",
"nextPage": "Points 2 and 3"
}) }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
{% set pageDescription = "Work out how your service helps improve health and well being, people's experience of health and care, and the efficiency of the health service and how you will know that you're succeeding." %}
{% set beta = true %}
{% set dateUpdated = "December 2019" %}
{% set backlog_issue_id = "344" %}

{% extends "includes/app-layout.njk" %}

Expand Down Expand Up @@ -48,16 +49,15 @@
<li><a href="https://www.england.nhs.uk/ourwork/patient-participation/self-care/patient-activation/">Patient activation</a> (NHS England)</li>
</ul>

<h3>Other help</h3>
<ul>
<li>Talk to us on the <a href="/slack">service manual Slack channel</a> or email the standards team at <a href="mailto:service-manual@nhs.net">service-manual@nhs.net</a>.</li>
</ul>
{% endblock %}

{{ pagination({
{% block afterContact %}

{{ pagination({
"previousUrl": "/service-standard/9-respect-and-protect-users-confidentiality-and-privacy",
"previousPage": "Point 9",
"nextUrl": "/service-standard/11-choose-the-right-tools-and-technology",
"nextPage": "Point 11"
}) }}

{% endblock %}
{% endblock %}
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
{% set pageDescription = "Choose tools and technology that let you build a good service in an efficient, cost effective way." %}
{% set beta = true %}
{% set dateUpdated = "December 2019" %}
{% set backlog_issue_id = "354" %}

{% extends "includes/app-layout.njk" %}

Expand Down Expand Up @@ -47,10 +48,9 @@
<li><a href="https://digital.nhs.uk/data-and-information/information-standards/information-standards-and-data-collections-including-extractions/publications-and-notifications/standards-and-collections/dcb3051-identity-verification-and-authentication-standard-for-digital-health-and-care-services">Identity verification and authentication standard for digital health and care services</a>, DCB3051 (NHS Digital)</li>
</ul>

<h3>Other help</h3>
<ul>
<li>Talk to us on the <a href="/slack">service manual Slack channel</a> or email the standards team at <a href="mailto:service-manual@nhs.net">service-manual@nhs.net</a>.</li>
</ul>
{% endblock %}

{% block afterContact %}

{{ pagination({
"previousUrl": "/service-standard/10-define-what-success-looks-like-and-be-open-about-how-your-service-is-performing",
Expand All @@ -59,4 +59,5 @@
"nextPage": "Point 12"
}) }}

{% endblock %}

{% endblock %}
13 changes: 7 additions & 6 deletions app/views/service-standard/12-make-new-source-code-open.njk
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
{% set pageDescription = "Make all new source code open and reusable, and publish it under appropriate licences." %}
{% set beta = true %}
{% set dateUpdated = "December 2019" %}
{% set backlog_issue_id = "355" %}

{% extends "includes/app-layout.njk" %}

Expand Down Expand Up @@ -43,16 +44,16 @@
<li><a href="https://technology.blog.gov.uk/2017/09/27/dont-be-afraid-to-code-in-the-open-heres-how-to-do-it-securely/">Don’t be afraid to code in the open: here’s how to do it securely</a> (GOV.UK blog, 2017)</li>
</ul>

<h3>Other help</h3>
<ul>
<li>Talk to us on the <a href="/slack">service manual Slack channel</a> or email the standards team at <a href="mailto:service-manual@nhs.net">service-manual@nhs.net</a>.</li>
</ul>
{% endblock %}

{{ pagination({
{% block afterContact %}

{{ pagination({
"previousUrl": "/service-standard/11-choose-the-right-tools-and-technology",
"previousPage": "Point 11",
"nextUrl": "/service-standard/13-use-and-contribute-to-open-standards-common-components-and-patterns",
"nextPage": "Point 13"
}) }}

{% endblock %}

{% endblock %}
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
{% set beta = true %}
{% set hideDescription = true %}
{% set dateUpdated = "December 2019" %}
{% set backlog_issue_id = "356" %}

{% extends "includes/app-layout.njk" %}

Expand Down Expand Up @@ -42,10 +43,9 @@
<li><a href="https://design-system.service.gov.uk/">GOV.UK Design System</a></li>
</ul>

<h3>Other help</h3>
<ul>
<li>Talk to us on the <a href="#">service manual Slack channel</a> or email the standards team at <a href="mailto:service-manual@nhs.net">service-manual@nhs.net</a>.</li>
</ul>
{% endblock %}

{% block afterContact %}

{{ pagination({
"previousUrl": "/service-standard/12-make-new-source-code-open",
Expand All @@ -54,4 +54,4 @@
"nextPage": "Point 14"
}) }}

{% endblock %}
{% endblock %}
10 changes: 5 additions & 5 deletions app/views/service-standard/14-operate-a-reliable-service.njk
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
{% set pageDescription = "People need the NHS 24 hours a day, every day of the year. Minimise service downtime and have a plan to deal with it when it does happen." %}
{% set beta = true %}
{% set dateUpdated = "December 2019" %}
{% set backlog_issue_id = "357" %}

{% extends "includes/app-layout.njk" %}

Expand Down Expand Up @@ -36,10 +37,9 @@
<li><a href="https://www.gov.uk/service-manual/technology/uptime-and-availability-keeping-your-service-online">Uptime and availability: keeping your service online</a></li>
</ul>

<h3>Other help</h3>
<ul>
<li>Talk to us on the <a href="#">service manual Slack channel</a> or email the standards team at <a href="mailto:service-manual@nhs.net">service-manual@nhs.net</a>.</li>
</ul>
{% endblock %}

{% block afterContact %}

{{ pagination({
"previousUrl": "/service-standard/13-use-and-contribute-to-open-standards-common-components-and-patterns",
Expand All @@ -48,4 +48,4 @@
"nextPage": "Point 15"
}) }}

{% endblock %}
{% endblock %}
13 changes: 7 additions & 6 deletions app/views/service-standard/15-support-a-culture-of-care.njk
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
{% set pageDescription = "Caring is the core business of the NHS. NHS services should provide a positive experience of care or help NHS staff provide a caring service." %}
{% set beta = true %}
{% set dateUpdated = "December 2019" %}
{% set backlog_issue_id = "358" %}

{% extends "includes/app-layout.njk" %}

Expand Down Expand Up @@ -56,16 +57,16 @@
<ul>
<li>The sections on <a href="https://www.cqc.org.uk/guidance-providers/healthcare/kindness-respect-compassion-healthcare-services">Kindness, respect and compassion</a>, <a href="https://www.cqc.org.uk/guidance-providers/healthcare/involving-people-decisions-about-their-care-healthcare-services">Involving people in decisions about their care</a>, and <a href="https://www.cqc.org.uk/guidance-providers/healthcare/privacy-dignity-healthcare-services">Privacy and dignity</a> in Key lines of enquiry for healthcare services (Care Quality Commission)</li>
</ul>
<h3>Other help</h3>
<ul>
<li>Talk to us on the <a href="/slack">service manual Slack channel</a> or email the standards team at <a href="mailto:service-manual@nhs.net">service-manual@nhs.net</a>.</li>
</ul>

{{ pagination({
{% endblock %}

{% block afterContact %}

{{ pagination({
"previousUrl": "/service-standard/14-operate-a-reliable-service",
"previousPage": "Point 14",
"nextUrl": "/service-standard/16-make-your-service-clinically-safe",
"nextPage": "Point 16"
}) }}

{% endblock %}
{% endblock %}
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
{% set pageDescription = "Digital information, tools and services have the potential to cause patient harm." %}
{% set beta = true %}
{% set dateUpdated = "December 2019" %}
{% set backlog_issue_id = "359" %}

{% extends "includes/app-layout.njk" %}

Expand Down Expand Up @@ -49,18 +50,16 @@
<li><a href="https://www.cqc.org.uk/guidance-providers/online/online-primary-care-services">Online primary care services</a> (Care Quality Commission) and <a href="https://www.cqc.org.uk/guidance-providers/online/how-we-monitor-inspect-regulate-online-primary-care">how the CQC monitors, inspects and regulates them</a></li>
<li><a href="https://www.england.nhs.uk/safeguarding/">Safeguarding</a> (NHS England)</li>
</ul>
<h3>Other help</h3>
<ul>
<li>Talk to us on the <a href="/slack">service manual Slack channel</a> or email the standards team at <a href="mailto:service-manual@nhs.net">service-manual@nhs.net</a>.</li>
<li>Contact the NHS Digital Clinical Safety team at <a href="mailto:assurance@nhs.net">assurance@nhs.net</a> or on 0300 303 5678.</li>
<li>Take up NHS Digital <a href="https://digital.nhs.uk/services/solution-assurance/the-clinical-safety-team/clinical-risk-management-training">clinical risk management training</a>.</li>
</ul>

{{ pagination({
{% endblock %}

{% block afterContact %}

{{ pagination({
"previousUrl": "/service-standard/15-support-a-culture-of-care",
"previousPage": "Point 15",
"nextUrl": "/service-standard/17-make-your-service-interoperable",
"nextPage": "Point 17"
}) }}

{% endblock %}
{% endblock %}
Loading