-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contextual links #1000 #1001 #1102
Conversation
@nancyhalladay24 Do you have any more changes to make to the service standard section before this goes to review? |
@Tosin-Balogun nope! Happy for it to be reviewed :D |
@@ -47,6 +47,9 @@ | |||
<p>If you have a Mac, <a href="https://www.apple.com/uk/accessibility/mac/vision/">try out VoiceOver</a>, or <a href="https://www.nvaccess.org/download/">download NVDA for Windows</a>.</p> | |||
<p>If you're not confident about doing this, book a session in an accessibility lab first.</p> | |||
|
|||
<h2 id="talk-to-other-people-with-an-interest-in-accessibility">Talk to other people with an interest in accessibility</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarawilcox - added the original section within the getting starting with accessibility page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Tosin, what about the text that follows? Is it still included?
Join the GOV.UK accessibility community or talk to NHS colleagues on our public Slack workspace to get advice and support, stay up to date and share examples.
I'd leave the text on the page as it is for now and drop the partial in underneath it. I can always change the text on the page if it doesn't work with the partial underneath.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Tosin, there isn't a partial on the What all NHS services need to do about accessibility page. Do you have time to sort that out? If not, I'll ask @AdamChrimes if he can help tomorrow.
@sarawilcox - This is intentional as that page is more about telling the user what it is and isn't primed for feedback. The theory for pages like this is that the 'get in touch' footer should work for those. Our main hypothesis focused on any page that goes into the 'how'. We also still have the hub partial to create which might serve this need
<p>If you have any questions, you can <a href="https://service-manual.nhs.uk/slack">message us on Slack</a>. You will need a Slack account if you do not have one. Or you can <a href="mailto:service-manual@nhs.net">contact us by email</a>. {% if pageTitle === "Getting started with accessibility" %} You can also <a href="https://www.gov.uk/service-manual/communities/accessibility-community">contact the GOV.UK accessibility community</a>.{% endif %} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarawilcox Added the partial style back in pending review with Leigh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Tosin, I think we need to take the mention of the GOV.UK community out of the partial. It's just part of the body content on the Getting started page.
@adam - added you as second reviewer pending when Sara completes all needed review for version 3.14.3 release tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot Tosin. I'll double-check it in staging. LGTM.
Hi Tosin, there isn't a partial on the What all NHS services need to do about accessibility page. Do you have time to sort that out? If not, I'll ask @AdamChrimes if he can help tomorrow. Update: Ignore this comment. Let's test it with users. |
Description
Creating contribution links within different user journeys for:
Made small style changes to fit each section
Related issue
#1000 #1001
Checklist
package.json
(using SEMVER)