Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devcontainer #458

Merged
merged 1 commit into from
May 31, 2024
Merged

Update devcontainer #458

merged 1 commit into from
May 31, 2024

Conversation

anngvu
Copy link
Collaborator

@anngvu anngvu commented May 30, 2024

OK, I see what's going on. So there was a typing_extensions issue that cropped up around April, and a workaround/fix was put into #421 but I neglected the .devcontainer 😞 .

Before patch:
image

After patch:
image

@anngvu anngvu requested review from allaway and cconrad8 May 30, 2024 15:11
Copy link

Test Suite Report 24.5.1

Template Generation

template result link
ClinicalAssayTemplate 😄 template link
EpigeneticsAssayTemplate 😄 template link
FlowCytometryTemplate 😄 template link
GenomicsAssayTemplate 😄 template link
GenomicsAssayTemplateExtended 😄 template link
HumanCohortTemplate 😄 template link
ImagingAssayTemplate 😄 template link
LightScatteringAssayTemplate 😄 template link
MethylationArrayTemplate 😄 template link
MRIAssayTemplate 😄 template link
PharmacokineticsAssayTemplate 😄 template link
PlateBasedReporterAssayTemplate 😄 template link
ProcessedAlignedReadsTemplate 😄 template link
ProcessedExpressionTemplate 😄 template link
ProcessedVariantCallsTemplate 😄 template link
ProteomicsAssayTemplate 😄 template link
ProtocolTemplate 😄 template link
RNASeqTemplate 😄 template link
ScRNASeqTemplate 😄 template link
UpdateMilestoneReport 😄 template link
WESTemplate 😄 template link
WGSTemplate 😄 template link

Manifest Validation

manifest result expectation
GenomicsAssayTemplate_0.csv 😄 Lists can be blank if attr not required using ‘list like’ rule
GenomicsAssayTemplate_1.csv 😄 Mixing blanks and regular list values works
GenomicsAssayTemplate_2.csv 😄 Conditional validation for attributes is currently not supported
GenomicsAssayTemplate_control.csv 😄 There should be no issue with this template.
ScRNASeqTemplate_0.csv 😄 Single list val works by using ‘list like’ rule
ScRNASeqTemplate_1.csv 😄 Fail because of missing data in required field libraryStrand

Manifest Submission

manifest pass
GenomicsAssayTemplate_0.csv 😄
GenomicsAssayTemplate_1.csv 😄
GenomicsAssayTemplate_2.csv 😄
GenomicsAssayTemplate_control.csv 😄
ScRNASeqTemplate_0.csv 😄

@anngvu anngvu merged commit 80cf112 into main May 31, 2024
2 checks passed
@anngvu anngvu deleted the patch/devcontainer branch May 31, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants