Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker.userEmulation #2580

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Remove docker.userEmulation #2580

merged 3 commits into from
Dec 19, 2023

Conversation

ewels
Copy link
Member

@ewels ewels commented Dec 18, 2023

This option is about to be stripped out of Nextflow itself, so we need to remove it from the nf-core template.

See nextflow-io/nextflow#4596

Should maybe consider adding a lint test that checks if the option is present? Though I don't think it'll trigger any errors or anything if left in, just be silently ignored. Setting docker.fooNotexists = true in a config seems to have no effect.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels requested a review from drpatelh December 18, 2023 13:59
@ewels
Copy link
Member Author

ewels commented Dec 18, 2023

See nextflow-io/nextflow#4601 for discussion about replacements.

@ewels ewels force-pushed the remove-userEmulation branch from 41ade9b to bb98c31 Compare December 19, 2023 08:55
@ewels
Copy link
Member Author

ewels commented Dec 19, 2023

Rebased the branch to try to sort out the git commit history. Hopefully ok to merge now.

ewels and others added 2 commits December 19, 2023 11:15
This option is about to be stripped out of Nextflow itself, so we need to remove it from the nf-core template.

See nextflow-io/nextflow#4596
@ewels ewels force-pushed the remove-userEmulation branch from bb98c31 to cf6291c Compare December 19, 2023 10:15
@ewels
Copy link
Member Author

ewels commented Dec 19, 2023

Third time lucky..

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e33989a) 75.06% compared to head (aa5febe) 75.06%.
Report is 7 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2580   +/-   ##
=======================================
  Coverage   75.06%   75.06%           
=======================================
  Files          85       85           
  Lines        9376     9376           
=======================================
  Hits         7038     7038           
  Misses       2338     2338           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mashehu mashehu merged commit 85407ed into dev Dec 19, 2023
20 checks passed
@mashehu mashehu deleted the remove-userEmulation branch December 19, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants