Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove undocumented userEmulation mode #4596

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

pditommaso
Copy link
Member

This PR removes the undocumented setting docker.userEmulation.

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit af9f6fc
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/65802d9968601b0008e6657d

ewels added a commit to nf-core/tools that referenced this pull request Dec 18, 2023
This option is about to be stripped out of Nextflow itself, so we need to remove it from the nf-core template.

See nextflow-io/nextflow#4596
@pditommaso pditommaso merged commit f6c7978 into master Dec 18, 2023
21 checks passed
@pditommaso pditommaso deleted the kill-user-emulation branch December 18, 2023 15:27
mirpedrol pushed a commit to nf-core/tools that referenced this pull request Dec 19, 2023
This option is about to be stripped out of Nextflow itself, so we need to remove it from the nf-core template.

See nextflow-io/nextflow#4596
ewels added a commit to nf-core/tools that referenced this pull request Dec 19, 2023
This option is about to be stripped out of Nextflow itself, so we need to remove it from the nf-core template.

See nextflow-io/nextflow#4596
ewels added a commit to nf-core/tools that referenced this pull request Dec 19, 2023
This option is about to be stripped out of Nextflow itself, so we need to remove it from the nf-core template.

See nextflow-io/nextflow#4596
@ewels
Copy link
Member

ewels commented Dec 19, 2023

Note that we also had a podman.userEmulation mentioned in one config file.

I'm not sure if this config option was hallucinated, or whether it actually exists.

@pditommaso
Copy link
Member Author

There's no such option in Podman

class PodmanBuilder extends ContainerBuilder<PodmanBuilder> {

@ewels
Copy link
Member

ewels commented Dec 19, 2023

Ok good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants