-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Drop container error to warning #2396
fix: Drop container error to warning #2396
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #2396 +/- ##
==========================================
+ Coverage 71.12% 71.14% +0.02%
==========================================
Files 87 87
Lines 9408 9410 +2
==========================================
+ Hits 6691 6695 +4
+ Misses 2717 2715 -2
|
f2032c4
to
c224ba4
Compare
Changes: - Container registries do not have a consistent API, so calling them for container presence doesn't seem to work on GHCR or NVCR. - This drops the error to a warning so we don't fail tests. Relates to nf-core/modules#3693 and nf-core#2393
c224ba4
to
67a84e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You guys think this is OK? I wasn't sure if it was a good idea, but then again I don't see how to solve the container problem. |
yeah, it's a bit of cheating, but if it will not be too much to the point that we just start ignoring these warnings, it is fine. |
Okey dokey, then let's goooo. |
Changes:
for container presence doesn't seem to work on GHCR or NVCR.
Relates to nf-core/modules#3693 and #2393
PR checklist
CHANGELOG.md
is updateddocs
is updated