Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting error related to GHCR container registry #3693

Closed
2 tasks done
asp8200 opened this issue Aug 3, 2023 · 2 comments
Closed
2 tasks done

Linting error related to GHCR container registry #3693

asp8200 opened this issue Aug 3, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@asp8200
Copy link
Contributor

asp8200 commented Aug 3, 2023

Have you checked the docs?

Description of the bug

Linting of fastk/fastk fails when run by GHA.

https://github.com/nf-core/modules/actions/runs/5748963436/job/15582864610?pr=3690

@adamrtalbot suspects that an "https" is being added to the front of the URL.

It is probably a general problem related to the GHCR container registry.

Command used and terminal output

No response

Relevant files

No response

System information

No response

@asp8200 asp8200 added the bug Something isn't working label Aug 3, 2023
@adamrtalbot
Copy link
Contributor

This also seems to affect other registries like NVCR.

container "nvcr.io/nvidia/clara/clara-parabricks:4.0.1-1"

adamrtalbot added a commit to adamrtalbot/tools that referenced this issue Aug 14, 2023
Changes:
 - Container registries do not have a consistent API, so calling them
   for container presence doesn't seem to work on GHCR or NVCR.
 - This drops the error to a warning so we don't fail tests.

Relates to nf-core/modules#3693 and nf-core#2393
adamrtalbot added a commit to adamrtalbot/tools that referenced this issue Aug 15, 2023
Changes:
 - Container registries do not have a consistent API, so calling them
   for container presence doesn't seem to work on GHCR or NVCR.
 - This drops the error to a warning so we don't fail tests.

Relates to nf-core/modules#3693 and nf-core#2393
adamrtalbot added a commit to adamrtalbot/tools that referenced this issue Aug 15, 2023
Changes:
 - Container registries do not have a consistent API, so calling them
   for container presence doesn't seem to work on GHCR or NVCR.
 - This drops the error to a warning so we don't fail tests.

Relates to nf-core/modules#3693 and nf-core#2393
@adamrtalbot
Copy link
Contributor

Resolved with nf-core/tools#2396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants