Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverse conda env handling (fix for #114) #122

Merged
merged 3 commits into from
Aug 10, 2018
Merged

Conversation

HadrienG
Copy link
Member

@HadrienG HadrienG commented Aug 9, 2018

No description provided.

@HadrienG
Copy link
Member Author

@ewels this is ready for review now 😄

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@ewels ewels merged commit 7152f8d into nf-core:master Aug 10, 2018
@ewels
Copy link
Member

ewels commented Aug 10, 2018

Ah crap, I just realised that I merged this into master. I'll revert as it'll cause problems otherwise.

@HadrienG - could you please open a new PR again and we'll merge into dev instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants