more prep work #1918
Merged
more prep work #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to it mostly for the `io::Write` impl, which some upcoming work needs.
Going to reuse this code for interactive info queries soon. Also do a small output change, going from ``` --- STDOUT: name of test --- ``` to ``` ---- STDOUT: name of test ``` The trailing `---` doesn't look great, and the extra hyphen in the beginning aligns `STDOUT:` properly.
* Add a `ChildAccumulator` struct that tracks the fds, output and errors externally. Tracking all this data externally means that interactive queries about the output can be satisfied. * Continue collecting output while the process is being terminated -- again to ensure that interactive queries are up-to-date. * Make `ChildError` cloneable by wrapping all the errors in `Arc`. child error handling 2
If we receive a stop or continue signal during terminate_child, it's important to account for that within the stopwatch.
45c9d48 to
334d1a3
Compare
|
The test coverage issue is taiki-e/cargo-llvm-cov#400. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been splitting and landing chunks of work out of #1911 as atomic commits.