Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nextest-runner] support pressing t to dump current test info #1911

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

sunshowers
Copy link
Member

@sunshowers sunshowers commented Nov 28, 2024

In prior work (#1938) we enabled the SIGUSR1 and SIGINFO handlers to dump internal state to standard output.

However, those handlers aren't present on all platforms.

  • SIGINFO doesn't exist on Linux. SIGUSR1 exists but is hard to send signals over (have to use kill, nothing like ^T).
  • Windows' very basic signal handling mechanism isn't really up to the task.

As an alternative, allow these platforms to specify t to dump current test information to the interactive terminal.

It would also be interesting to support a Unix domain socket as a way to query current state in the future, and have a separate instance of nextest be able to connect to the socket -- this work naturally builds towards that kind of model.

@sunshowers sunshowers mentioned this pull request Nov 29, 2024
@sunshowers sunshowers force-pushed the interactive branch 2 times, most recently from 2ed113b to 1c63cc5 Compare December 4, 2024 22:20
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 33.13609% with 113 lines in your changes missing coverage. Please review.

Project coverage is 79.94%. Comparing base (1833ee8) to head (9a73de9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nextest-runner/src/input.rs 13.55% 102 Missing ⚠️
nextest-runner/src/runner.rs 85.71% 5 Missing ⚠️
nextest-runner/src/reporter/displayer.rs 0.00% 4 Missing ⚠️
cargo-nextest/src/dispatch.rs 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1911      +/-   ##
==========================================
- Coverage   80.28%   79.94%   -0.35%     
==========================================
  Files          83       84       +1     
  Lines       22080    22226     +146     
==========================================
+ Hits        17728    17768      +40     
- Misses       4352     4458     +106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunshowers sunshowers force-pushed the interactive branch 3 times, most recently from 7ebde33 to 099ea83 Compare December 5, 2024 01:57
@sunshowers sunshowers changed the title [WIP] interactive test queries [nextest-runner] support pressing t to dump current test info Dec 5, 2024
@sunshowers sunshowers marked this pull request as ready for review December 5, 2024 02:46
@sunshowers sunshowers merged commit e2f5950 into nextest-rs:main Dec 5, 2024
19 checks passed
@sunshowers sunshowers deleted the interactive branch December 5, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant