-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch default privacy scopes and set properties appropriate #1048
Fetch default privacy scopes and set properties appropriate #1048
Conversation
5274df5
to
c1dd620
Compare
…stead of using 'v2-local' (closes nextcloud#1047) Signed-off-by: Björn Bores <bjalbor@gmail.com>
c1dd620
to
9aabd12
Compare
I had to force-push because I somehow missed to check if a default value for BIRTHDAY is already available for using in case of gender (which is - like PRONOUNS - not availible before NC v31). Sorry for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR!
A few minor change requests and we're good to go.
If you rebase on the main branch, you'll get rid of one Psalm issue ( The other one ( |
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Björn Bores <bores@bjalbor.com>
Thanks for the changes. Just a few more things to turn the CI green:
git checkout main
git pull https://github.com/nextcloud/user_oidc main
git checkout feat/1047/user-provisioning-privacy-scopes
git rebase main
git push YOUR_REPO YOUR_BRANCH |
Signed-off-by: Björn Bores <bores@bjalbor.com>
d1e5e04
to
802f2fe
Compare
Thanks a lot for the fixes and for your patience! |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Fetch default values for privacy scopes and use these for user provisioning instead of always take 'v2-local' which will reveal sensitive information on default (closes #1047)