Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch default privacy scopes and set properties appropriate #1048

Merged

Conversation

bjalbor
Copy link
Contributor

@bjalbor bjalbor commented Feb 7, 2025

Fetch default values for privacy scopes and use these for user provisioning instead of always take 'v2-local' which will reveal sensitive information on default (closes #1047)

@bjalbor bjalbor force-pushed the feat/1047/user-provisioning-privacy-scopes branch 2 times, most recently from 5274df5 to c1dd620 Compare February 7, 2025 13:26
…stead of using 'v2-local' (closes nextcloud#1047)

Signed-off-by: Björn Bores <bjalbor@gmail.com>
@bjalbor bjalbor force-pushed the feat/1047/user-provisioning-privacy-scopes branch from c1dd620 to 9aabd12 Compare February 7, 2025 13:43
@bjalbor
Copy link
Contributor Author

bjalbor commented Feb 7, 2025

I had to force-push because I somehow missed to check if a default value for BIRTHDAY is already available for using in case of gender (which is - like PRONOUNS - not availible before NC v31). Sorry for that.

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR!

A few minor change requests and we're good to go.

@julien-nc
Copy link
Member

If you rebase on the main branch, you'll get rid of one Psalm issue (UndefinedConstant: Constant OCP\Accounts\IAccountManager::PROPERTY_FEDIVERSE is not defined).

The other one (UndefinedClass: Class, interface or enum named OC\Accounts\AccountManager does not exist) I can fix later.

julien-nc and others added 3 commits February 10, 2025 17:10
@bjalbor bjalbor requested a review from julien-nc February 10, 2025 19:21
@julien-nc
Copy link
Member

Thanks for the changes. Just a few more things to turn the CI green:

  • Run composer i ; composer run cs:fix to fix the indentation
  • Add <referencedClass name="OC\Accounts\AccountManager" /> after line 46 of the /psalm.xml file. This will fix the psalm error.
  • Update your local main branch and rebase your branch on top of it. As there is no conflict, the rebase is painless:
git checkout main
git pull https://github.com/nextcloud/user_oidc main
git checkout feat/1047/user-provisioning-privacy-scopes
git rebase main
git push YOUR_REPO YOUR_BRANCH

Björn Bores added 2 commits February 11, 2025 19:43
Signed-off-by: Björn Bores <bores@bjalbor.com>
Signed-off-by: Björn Bores <bores@bjalbor.com>
@bjalbor bjalbor force-pushed the feat/1047/user-provisioning-privacy-scopes branch from d1e5e04 to 802f2fe Compare February 11, 2025 18:50
@julien-nc julien-nc merged commit d1bdb8f into nextcloud:main Feb 12, 2025
51 checks passed
@julien-nc
Copy link
Member

Thanks a lot for the fixes and for your patience!

@julien-nc julien-nc mentioned this pull request Feb 17, 2025
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@bjalbor bjalbor deleted the feat/1047/user-provisioning-privacy-scopes branch February 23, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provisioning of new users doesn't take default/configured privacy scopes into account
2 participants