Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix emoji autocompletion keyboard behaviour #2863

Merged
merged 4 commits into from
Sep 13, 2022
Merged

Fix emoji autocompletion keyboard behaviour #2863

merged 4 commits into from
Sep 13, 2022

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Sep 6, 2022 •
edited
Loading

  • When emoji picker is open, Esc should only close emoji picker, not the full editor modal (This needs to be tackled seperately, we have Escape key should not close the editor #2199 to track it.)
  • Tab should insert the selected emoji
  • When emoji picker is open, Esc followed by Return inserts the last selected emoji. This should not happen. It's only reproducible in public shares or Collectives right now, due to the fact that Esc closes the whole editor modal in other cases.

Resolves: #2785

@mejo- mejo- self-assigned this Sep 6, 2022
@mejo- mejo- force-pushed the fix/emoji_list_keys branch from 85b42db to de94136 Compare September 6, 2022 08:28
@mejo-
Copy link
Member Author

mejo- commented Sep 6, 2022

/compile

@mejo- mejo- force-pushed the fix/emoji_list_keys branch from de94136 to 3b6fe5b Compare September 6, 2022 08:37
@mejo-
Copy link
Member Author

mejo- commented Sep 6, 2022

/compile

@mejo-
Copy link
Member Author

mejo- commented Sep 6, 2022

  • When emoji picker is open, Esc should only close emoji picker, not the full editor modal

This needs to be tackled seperately, we have #2199 to track it.

@mejo- mejo- marked this pull request as ready for review September 6, 2022 08:38
@mejo-
Copy link
Member Author

mejo- commented Sep 6, 2022

/backport to stable24

@mejo- mejo- requested a review from luka-nextcloud September 6, 2022 08:57
@mejo- mejo- force-pushed the fix/emoji_list_keys branch from 33b2163 to 7ea81cc Compare September 6, 2022 09:40
@mejo-
Copy link
Member Author

mejo- commented Sep 6, 2022

/compile

@mejo-
Copy link
Member Author

mejo- commented Sep 6, 2022

/rebase

@mejo-
Copy link
Member Author

mejo- commented Sep 8, 2022

/rebase

@mejo- mejo- force-pushed the fix/emoji_list_keys branch from b62e6ae to fd543d8 Compare September 8, 2022 09:27
@mejo-
Copy link
Member Author

mejo- commented Sep 8, 2022

/compile

1 similar comment
@mejo-
Copy link
Member Author

mejo- commented Sep 8, 2022

/compile

@mejo-
Copy link
Member Author

mejo- commented Sep 9, 2022

/rebase

@mejo-
Ignore keyboard combinations with modifiers in emoji selector list
1bcf041 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
Allow to select emojis with tab key
f090c52 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
Stop emoji autocompletion when it got escaped by hitting <Esc>
6eb324f 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/emoji_list_keys branch from e828d86 to 013f725 Compare September 13, 2022 08:56
@max-nextcloud
Copy link
Collaborator

/compile amend /

@nextcloud-command
Compile assets
1f2503e 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
max-nextcloud
max-nextcloud approved these changes Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I'll try it and then merge.

@max-nextcloud max-nextcloud merged commit a6ebb4d into master Sep 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/emoji_list_keys branch September 13, 2022 09:14
@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@mejo-
Copy link
Member Author

mejo- commented Sep 13, 2022

/backport 1bcf041,f090c52317aebfdc36a6d965d2307fdf100139ee,6eb324f144b3761fc153dacc75b14e3e9b35d0cf to stable24

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 13, 2022
Merged
1 task
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@vinicius73 vinicius73 Awaiting requested review from vinicius73

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

Assignees

@mejo- mejo-

Labels
3. to review accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missleading keyboard behaviour in emoji picker
3 participants
@mejo- @max-nextcloud @nextcloud-command