Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missleading keyboard behaviour in emoji picker #2785

Closed
3 tasks
mejo- opened this issue Aug 10, 2022 · 2 comments · Fixed by #2863
Closed
3 tasks

Missleading keyboard behaviour in emoji picker #2785

mejo- opened this issue Aug 10, 2022 · 2 comments · Fixed by #2863
Labels
accessibility bug Something isn't working

Comments

@mejo-
Copy link
Member

mejo- commented Aug 10, 2022

Describe the bug
There's room for improvement in the keyboard navigation in emoji picker:

  • When emoji picker is open, Esc should only close emoji picker, not the full editor modal
  • Tab should insert the selected emoji
  • When emoji picker is open, Esc followed by Return inserts the last selected emoji. This should not happen. It's only reproducible in public shares or Collectives right now, due to the fact that Esc closes the whole editor modal in other cases.
@mejo- mejo- added bug Something isn't working accessibility labels Aug 10, 2022
@PVince81
Copy link
Member

unclear whether this needs a fix in the emoji picker or on the text app side (ex: prevent event bubbling) ?

for emoji picker issues specifically, please raise in the nextcloud-vue repo

@mejo-
Copy link
Member Author

mejo- commented Sep 5, 2022

Upstream issue regarding the unexpected behaviourt with Esc followed by Return: ueberdosis/tiptap#3063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants