Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reactions endpoints not accessible by guests #7205

Merged
merged 3 commits into from
Apr 25, 2022
Merged

Fix reactions endpoints not accessible by guests #7205

merged 3 commits into from
Apr 25, 2022

Conversation

danxuliu
Copy link
Member

@danxuliu danxuliu commented Apr 22, 2022 •
edited by nickvergessen
Loading

Pending:

  • Add integration tests
  • The WebUI should show a name placeholder in the list of "reacters" if a guest has no name

@danxuliu
Fix reactions endpoints not accessible by guests
36cb3d0 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu danxuliu added this to the 💚 Next Major (25) milestone Apr 22, 2022
@nickvergessen
Fix representation of guest reactions
e13ad50 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Add integration tests for guest reactions
b73eb9f 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen marked this pull request as ready for review April 25, 2022 15:25
@nickvergessen
Copy link
Member

/backport to stable24

@danxuliu
Copy link
Member Author

danxuliu commented Apr 25, 2022 •
edited
Loading

Tested and works 👍

It would be nice to add (either here or in another pull request) integration tests for getReactions() (the integration tests currently check the basic information included in the message, but not the extended one with the participants provided by getReactions()) as well as unit tests for the summary.

@nickvergessen nickvergessen mentioned this pull request Apr 25, 2022
Closed
@nickvergessen nickvergessen merged commit 2ad2aad into master Apr 25, 2022
@nickvergessen nickvergessen deleted the fix-reactions-endpoints-not-accessible-by-guests branch April 25, 2022 19:05
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@vitormattos vitormattos vitormattos approved these changes

Assignees
No one assigned
Labels
4. to release bug feature: reactions 👍
Projects
None yet
Milestone
v15.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@danxuliu @nickvergessen @vitormattos