Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit integration (and unit?) tests for the summary #7216

Closed
Tracked by #7232
nickvergessen opened this issue Apr 25, 2022 · 3 comments
Closed
Tracked by #7232

Explicit integration (and unit?) tests for the summary #7216

nickvergessen opened this issue Apr 25, 2022 · 3 comments
Labels
1. to develop feature: api 🛠️ OCS API for conversations, chats and participants feature: reactions 👍

Comments

@nickvergessen
Copy link
Member

It would be nice to add (either here or in another pull request) integration tests for getReactions() (the integration tests currently check the basic information included in the message, but not the extended one with the participants provided by getReactions()) as well as unit tests for the summary.

Originally posted by @danxuliu in #7205 (comment)

@vitormattos
Copy link
Contributor

Related PR: nextcloud/server#32220

@nickvergessen
Copy link
Member Author

nickvergessen commented May 2, 2022

Seems you misunderstood.
Basically the idea is that:
https://github.com/nextcloud/spreed/blob/master/tests/integration/features/reaction/react.feature
Should have a check like:

    Then user "participant1" sees the following reactions on message "Message 1" in room "room" with 200
      | room | actorType | actorId      | actorDisplayName         | reaction |
      | room | guests    | guest        |                          | 👤 |
      | room | users     | participant1 | participant1-displayname | 👍 |
      | room | users     | participant1 | participant1-displayname | 🚀 |
      | room | users     | participant2 | participant2-displayname | 👍 |

But that check does not yet exist

@nickvergessen
Copy link
Member Author

Done in

And user "participant1" retrieve reactions "all" of message "Message 1" in room "room" with 200
| actorType | actorId | actorDisplayName | reaction |
| users | participant1 | participant1-displayname | 👍 |
| users | participant2 | participant2-displayname | 👎 |
| users | participant2 | participant2-displayname | 👍 |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop feature: api 🛠️ OCS API for conversations, chats and participants feature: reactions 👍
Projects
None yet
Development

No branches or pull requests

2 participants