Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(callView): reset promoted view once switched to Grid mode #14333

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(callView): reset promoted view once switched to Grid mode #14333

wants to merge 3 commits into from
+77 −42

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏡 After

2025-02-10_16h38_20.mp4

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🪺 Next Major (32) milestone Feb 10, 2025
@Antreesy Antreesy requested a review from ShGKme February 10, 2025 15:39
@Antreesy Antreesy self-assigned this Feb 10, 2025
@Antreesy
fix(callView): reset promoted view once switched to Grid mode
2793e3c 
- do not use presentation flag for selected videos
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(callView): rename to .ts
c189755 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
fix(callView): migrate to typescript
188e1da 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/14325/reset-promoted branch from 69e5e59 to 188e1da Compare February 10, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme Awaiting requested review from ShGKme

At least 1 approving review is required to merge this pull request.

Assignees

@Antreesy Antreesy

Labels
3. to review bug feature: call 📹 Voice and video calls feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.

Can't switch back to promoted mode once moved from promoted mode to grid mode
1 participant
@Antreesy