Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MessagesList): do not replace container when switching conversations #14327

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −3
Open

fix(MessagesList): do not replace container when switching conversations #14327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11dac68
fix(MessagesList): do not replace container when switching conversations
Antreesy Feb 9, 2025
785fdea
fix(MessagesList): do not reset scrolledToBottom for non-scrollable c…
Antreesy Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/components/MessagesList/MessagesList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
<!-- size and remain refer to the amount and initial height of the items that
are outside of the viewport -->
<div ref="scroller"
:key="token"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was added during messages list soft update refactoring, but now it seems to be covered with messagesList watcher
With key in place, ResizeObserver loses reference to the scroller

class="scroller messages-list__scroller"
:class="{'scroller--chatScrolledToBottom': isChatScrolledToBottom,
'scroller--isScrolling': isScrolling}"
Expand Down Expand Up @@ -387,6 +386,9 @@ export default {
this.$refs.scroller.scrollTo({
top: this.$refs.scroller.scrollHeight,
})
} else if (this.$refs.scroller.clientHeight === this.$refs.scroller.scrollHeight) {
// chat is not scrollable
this.setChatScrolledToBottom(true)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For non-scrollable chats, removes the scroll to bottom on resize

}
},

Expand Down Expand Up @@ -931,10 +933,10 @@ export default {
this.displayMessagesLoader = false
this.debounceUpdateReadMarkerPosition()
return
} else if (scrollHeight > clientHeight) {
this.setChatScrolledToBottom(false)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After swtiching to conversation, handleScroll is triggered. Regardless of container height, it sets value to false (whereas it shouldn't for non-scrollable chats)

}

this.setChatScrolledToBottom(false)

if ((scrollHeight > clientHeight && scrollTop < 800 && this.isScrolling === 'up')
|| skipHeightCheck) {
if (this.loadingOldMessages || this.isChatBeginningReached) {
Expand Down
Loading