fix(MessagesList): do not replace container when switching conversations #14327
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
…hats Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
|
Could you explain the change? |
Antreesy
commented
Feb 10, 2025
| @@ -7,7 +7,6 @@ | |||
| <!-- size and remain refer to the amount and initial height of the items that | |||
| are outside of the viewport --> | |||
| <div ref="scroller" | |||
| :key="token" | |||
There was a problem hiding this comment.
Was added during messages list soft update refactoring, but now it seems to be covered with messagesList watcher
With key in place, ResizeObserver loses reference to the scroller
| @@ -387,6 +386,9 @@ export default { | |||
| this.$refs.scroller.scrollTo({ | |||
| top: this.$refs.scroller.scrollHeight, | |||
| }) | |||
| } else if (this.$refs.scroller.clientHeight === this.$refs.scroller.scrollHeight) { | |||
| // chat is not scrollable | |||
| this.setChatScrolledToBottom(true) | |||
There was a problem hiding this comment.
For non-scrollable chats, removes the scroll to bottom on resize
| @@ -931,10 +933,10 @@ export default { | |||
| this.displayMessagesLoader = false | |||
| this.debounceUpdateReadMarkerPosition() | |||
| return | |||
| } else if (scrollHeight > clientHeight) { | |||
| this.setChatScrolledToBottom(false) | |||
There was a problem hiding this comment.
After swtiching to conversation, handleScroll is triggered. Regardless of container height, it sets value to false (whereas it shouldn't for non-scrollable chats)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏡 After
2025-02-10_09h13_03.mp4
🏁 Checklist