Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More tests for getMemory, getCPUName and getUptime #202

Merged
merged 1 commit into from
Apr 30, 2020
Merged

More tests for getMemory, getCPUName and getUptime #202

merged 1 commit into from
Apr 30, 2020

Conversation

kesselb
Copy link
Collaborator

@kesselb kesselb commented Apr 17, 2020 •
edited
Loading

Notable changes

  • Make $cpuinfo, $meminfo and $uptime local variables again.
  • Changed readContent to throw an exception if file_get_contents returns false or empty.
  • preg_match_all returns 0 if the subject does not match the pattern.
  • More tests 🚀

@kesselb kesselb force-pushed the enh/more-tests-memory-cpuname branch 3 times, most recently from 773ace2 to c5686f3 Compare April 18, 2020 09:38
@kesselb
Add more tests for getMemory, getCPUName and getUptime
dd50612 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the enh/more-tests-memory-cpuname branch from f0e4db1 to dd50612 Compare April 18, 2020 19:13
@kesselb kesselb marked this pull request as ready for review April 18, 2020 19:14
@kesselb kesselb requested review from rullzer and MorrisJobke April 18, 2020 19:14
@kesselb kesselb added this to the Nextcloud 19 milestone Apr 24, 2020
@rullzer rullzer mentioned this pull request Apr 25, 2020
Merged
11 tasks
rullzer
rullzer approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer rullzer merged commit 9dfa5dd into master Apr 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the enh/more-tests-memory-cpuname branch April 30, 2020 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees
No one assigned
Labels
3. to review enhancement
Projects
None yet
Milestone
Nextcloud 19
Development

Successfully merging this pull request may close these issues.
2 participants
@kesselb @rullzer