Add test case for supported

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
nextcloud · Apr 18, 2020 · 773ace2 · 773ace2
1 parent 8270cba
commit 773ace2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/lib/OperatingSystems/DefaultOs.php b/lib/OperatingSystems/DefaultOs.php
@@ -29,7 +29,7 @@ class DefaultOs {
 	/**
 	 * @return bool
 	 */
-	public function supported() {
+	public function supported(): bool {
 		return true;
 	}
 
@@ -251,12 +251,4 @@ protected function executeCommand(string $command): string {
 		}
 		return $output;
 	}
-
-	protected function executeCommand(string $command): string {
-		$output = @shell_exec(escapeshellcmd($command));
-		if ($output === null || $output === '') {
-			throw new \RuntimeException('No output for command: "' . $command . '"');
-		}
-		return $output;
-	}
 }
diff --git a/tests/lib/DefaultOsTest.php b/tests/lib/DefaultOsTest.php
@@ -124,6 +124,7 @@ public function testGetUptimeNoData(): void {
 
 		$this->assertEquals(-1, $this->os->getUptime());
 	}
+
 	public function testGetDiskInfo(): void {
 		$this->os->method('executeCommand')
 			->with('df -TP')
@@ -182,4 +183,8 @@ public function testGetDiskInfoInvalidCommandOutput(): void {
 
 		$this->assertSame([], $this->os->getDiskInfo());
 	}
+
+	public function testSupported(): void {
+		$this->assertTrue($this->os->supported());
+	}
 }