hide settings menu when ctrl+click'ing on an entry #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome stuff, works perfectly! 👍 cc @skjnldsv @nickvergessen for review |
|
Great stuff @ChristophWurst! I just have one small request, could you extend it to also work with the middle click? I think the middle click is still the most used way to open something in a new tab if you work with a real mouse. |
|
Duplicate of #652 -> please try to get your stuff into the other PR. I will close this for now. |
|
@ChristophWurst Next time just check to open PRs that are linked to an issue first ;) Would have avoid duplicates ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #616
cc @jancborchardt @nextcloud/javascript