Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl-click on entries in the user menu will keep spinner spinning #616

Closed
jancborchardt opened this issue Jul 28, 2016 · 2 comments
Closed

Ctrl-click on entries in the user menu will keep spinner spinning #616

jancborchardt opened this issue Jul 28, 2016 · 2 comments
Assignees
@ChristophWurst
Labels
3. to review Waiting for reviews bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Milestone
Nextcloud 11.0

Comments

@jancborchardt
Copy link
Member

When you Ctrl-click on entries in the Apps menu on the top left, the spinner does not show and the menu closes directly – which is the correct behavior.

When you Ctrl-click on entries in the User menu on the top right, the menu stays open and the spinner is shown indefinitely. This should be fixed to behave as the apps menu does. :)

cc @nextcloud/javascript
@jancborchardt jancborchardt added bug 1. to develop Accepted and waiting to be taken care of good first issue Small tasks with clear documentation about how and in which place you need to fix things in. labels Jul 28, 2016
@MorrisJobke
Copy link
Member

See owncloud/core#23914 for the implementation in the apps menu

@jancborchardt
Copy link
Member Author

cc @ChristophWurst since you fixed it for the apps menu. ;)

Faldon pushed a commit to Faldon/server that referenced this issue Jul 29, 2016
Fixed user menu to not show spinner on ctrl+click.
5a6bde9 
Fixes nextcloud#616
@Faldon Faldon mentioned this issue Jul 29, 2016
Closed
@ChristophWurst ChristophWurst self-assigned this Jul 29, 2016
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jul 29, 2016
@ChristophWurst ChristophWurst mentioned this issue Jul 29, 2016
Closed
Faldon pushed a commit to Faldon/server that referenced this issue Aug 8, 2016
@Faldon
Fixed user menu to not show spinner on ctrl+click.
ceb5009 
Fixes nextcloud#616
@MorrisJobke MorrisJobke added this to the Nextcloud 11.0 milestone Aug 18, 2016
GitHubUser4234 pushed a commit to GitHubUser4234/server that referenced this issue Aug 30, 2016
@MorrisJobke
Fixed user menu to not show spinner on ctrl+click.
d848382 
Fixes nextcloud#616
@Hoerli1337 Hoerli1337 mentioned this issue Nov 6, 2017
Closed
@nextcloud-bot nextcloud-bot mentioned this issue Aug 7, 2018
Closed
@nextcloud-bot nextcloud-bot mentioned this issue Aug 16, 2018
Closed
@yesiamdollar yesiamdollar mentioned this issue Nov 28, 2023
Open
@yesiamdollar yesiamdollar mentioned this issue Dec 14, 2023
Open
@yesiamdollar yesiamdollar mentioned this issue Dec 31, 2023
Open
@yesiamdollar yesiamdollar mentioned this issue Oct 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Milestone
Nextcloud 11.0
3 participants
@MorrisJobke @jancborchardt @ChristophWurst