-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OCM implementation has wrong parameter names #50069
Conversation
44982b9
to
6aaefe2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but you need to change the commit message to follow https://www.conventionalcommits.org/en/v1.0.0/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @michielbdejong. Please clean-up the commit message and should be good.
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
…ud#36340 Signed-off-by: Michiel de Jong <michiel@pondersource.com>
6aaefe2
to
dacb1d9
Compare
I added 'fix:' to the beginning of the message, but left the ', fixes #36340' at the end of the description, since it felt informative and I didn't find anything in https://www.conventionalcommits.org/en/v1.0.0/ about how to use closing keywords. But let me know if you want that removed or changed as well. |
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Summary
Copy
sharedBy
andsharedByDisplayName
fields tosender
andsenderDisplayName
to allow non-Nextcloud implementations of Open Cloud Mesh to find this information when receiving a share from a nextcloud user.Checklist