Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OCM implementation has wrong parameter names #50069

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

michielbdejong
Copy link
Contributor

Summary

Copy sharedBy and sharedByDisplayName fields to sender and senderDisplayName to allow non-Nextcloud implementations of Open Cloud Mesh to find this information when receiving a share from a nextcloud user.

Checklist

@michielbdejong
Copy link
Contributor Author

CC @provokateurin @ArtificialOwl

Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you need to change the commit message to follow https://www.conventionalcommits.org/en/v1.0.0/

Copy link
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @michielbdejong. Please clean-up the commit message and should be good.

@blizzz blizzz mentioned this pull request Jan 8, 2025
This was referenced Jan 14, 2025
@Altahrim Altahrim mentioned this pull request Jan 21, 2025
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@Altahrim Altahrim mentioned this pull request Jan 23, 2025
@blizzz blizzz mentioned this pull request Jan 29, 2025
1 task
@blizzz blizzz modified the milestones: Nextcloud 31, Nextcloud 32 Jan 29, 2025
…ud#36340

Signed-off-by: Michiel de Jong <michiel@pondersource.com>
@michielbdejong
Copy link
Contributor Author

I added 'fix:' to the beginning of the message, but left the ', fixes #36340' at the end of the description, since it felt informative and I didn't find anything in https://www.conventionalcommits.org/en/v1.0.0/ about how to use closing keywords. But let me know if you want that removed or changed as well.

@nickvergessen nickvergessen changed the title Fix #36340 Fix OCM implementation has wrong parameter names Jan 29, 2025
@nickvergessen nickvergessen merged commit 8be4ad7 into nextcloud:master Feb 3, 2025
174 of 179 checks passed
Copy link

welcome bot commented Feb 3, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: OCM implementation has wrong parameter names
5 participants