[Bug]: OCM implementation has wrong parameter names

[provokateurin]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• Nextcloud Server is running on 64bit capable CPU, PHP and OS.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

https://github.com/nextcloud/server/blob/master/apps/cloud_federation_api/lib/Controller/RequestHandlerController.php#L115-L116 contains sharedBy and sharedByDisplayName, but neither is documented in the OCM spec (1.0 or latest). The spec contains sender and senderDisplayName so the variables names in the implementation are probably just wrong.

cc @schiessle

Steps to reproduce

Expected behavior

Correct implementation of the spec

Installation method

None

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

No response

List of activated Apps

-

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

[michielbdejong]

@ArtificialOwl can I send you a PR that fixes this issue?

[provokateurin]

@michielbdejong feel free to open a PR and tag the relevant people for a PR. You can also tag me in there as well.