[stable25] Link reference provider: Improve content-type check #36053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
approved these changes
Jan 9, 2023
mejo-
approved these changes
Jan 9, 2023
juliusknorr
approved these changes
Jan 9, 2023
PVince81
reviewed
Jan 10, 2023
| if ($linkContentType !== 'text/html') { | ||
| $expectedContentType = 'text/html'; | ||
| // check the header begins with the expected content type | ||
| if (substr($linkContentType, 0, strlen($expectedContentType)) !== $expectedContentType) { |
There was a problem hiding this comment.
maybe we should match "text/html;" with semicolon, otherwise "text/html5" or anything else would match as well
There was a problem hiding this comment.
The value can also just be text/html so we would need to cover both cases:
- value is exactly
text/html - OR value starts with
text/html;
Right?
… with text/html Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
7dfb22d to
e9dc352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #36043