Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link reference provider: Improve content-type check #36043

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Link reference provider: Improve content-type check #36043

merged 1 commit into from
Jan 9, 2023

Conversation

julien-nc
Copy link
Member

@julien-nc julien-nc commented Jan 9, 2023 •
edited
Loading

closes #36042
The content-type sometimes contains the charset:

content-type: text/html; charset=utf-8

So the link provider check was too strict. We now check it begins with text/html.

@julien-nc
in the link reference provider, check if the link content type begins…
b07addd 
… with text/html

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc added this to the Nextcloud 26 milestone Jan 9, 2023
mejo-
mejo- approved these changes Jan 9, 2023
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, thanks for tackling this.

@julien-nc
Copy link
Member Author

/backport to stable25

@julien-nc julien-nc requested a review from szaimen January 9, 2023 13:30
szaimen
szaimen approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 9, 2023
@PVince81 PVince81 merged commit 79f1c30 into master Jan 9, 2023
@PVince81 PVince81 deleted the fix/36042/link-reference-less-strict-content-type-check branch January 9, 2023 14:13
@juliusknorr
Copy link
Member

/backport to stable25

@juliusknorr juliusknorr mentioned this pull request Jan 9, 2023
Closed
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@szaimen szaimen szaimen approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug integration
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.

[Bug]: Resolving opengraph link broken with latest master
5 participants
@julien-nc @juliusknorr @mejo- @szaimen @PVince81