Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable22] Add share search tweaks #32996

Merged
merged 8 commits into from
Jul 7, 2022
Merged

[stable22] Add share search tweaks #32996

merged 8 commits into from
Jul 7, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jun 23, 2022 •
edited by artonge
Loading

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #32322

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 22.2.10 milestone Jun 23, 2022
@artonge artonge changed the title [stable22] [stable23] Add share search tweaks [stable22] Add share search tweaks Jun 23, 2022
@blizzz blizzz added the 2. developing Work in progress label Jun 24, 2022
@artonge artonge force-pushed the backport/32322/stable22 branch from 056ccc6 to 4e3f95a Compare June 27, 2022 09:19
@artonge
Copy link
Contributor

artonge commented Jun 28, 2022

/rebase

@nextcloud-command nextcloud-command force-pushed the backport/32322/stable22 branch from 4e3f95a to 54b0381 Compare June 28, 2022 09:55
@artonge
Copy link
Contributor

artonge commented Jun 28, 2022

CI failure unrelated

@skjnldsv skjnldsv mentioned this pull request Jul 5, 2022
Merged
8 tasks
@blizzz blizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 6, 2022
@skjnldsv
Copy link
Member

skjnldsv commented Jul 7, 2022

Conflicts @artonge 🙈

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 7, 2022
artonge added 7 commits July 7, 2022 12:41
@artonge
Add settings to not match userID during full match
3b2d69c 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Tweak tests to include shareapi_restrict_user_enumeration_full_match_…
1d6ecf4 
…userid

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Add settings to ignore second display name in search
752a9fa 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Add setting to ignore email during search
3ecb7da 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Use share setting in DAV search
831937e 
shareapi_restrict_user_enumeration_full_match_ignore_second_display_name was introduced to ignore second display name during search from the share panel. But this setting was not respected by search from the calendar application. This fix it.

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Use email settings in DAV search
2f2b8ef 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
FInish backport to stable22 of #32322
7a454a7 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the backport/32322/stable22 branch from 54b0381 to 7a454a7 Compare July 7, 2022 10:45
@artonge
Restore enforceLinkPassword
30d72b5 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the backport/32322/stable22 branch from 752d090 to 30d72b5 Compare July 7, 2022 10:47
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Jul 7, 2022
@artonge artonge merged commit f010a72 into stable22 Jul 7, 2022
@artonge artonge deleted the backport/32322/stable22 branch July 7, 2022 14:36
@skjnldsv skjnldsv mentioned this pull request Jul 8, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@artonge artonge Awaiting requested review from artonge

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: search feature: sharing
Projects
None yet
Milestone
Nextcloud 22.2.10
Development

Successfully merging this pull request may close these issues.
3 participants
@artonge @skjnldsv @blizzz