Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable23] Add share search tweaks #32322

Merged
merged 6 commits into from
Jun 23, 2022
Merged

[stable23] Add share search tweaks #32322

merged 6 commits into from
Jun 23, 2022

Conversation

artonge
Copy link
Contributor

@artonge artonge commented May 10, 2022

@artonge artonge added this to the Nextcloud 23.0.5 milestone May 10, 2022
@artonge artonge self-assigned this May 10, 2022
@artonge artonge changed the title [stable22] Add share search tweaks [stable23] Add share search tweaks May 10, 2022
@artonge
Copy link
Contributor Author

artonge commented May 10, 2022

/backport to stable22

@artonge artonge requested review from a team, PVince81, ArtificialOwl and CarlSchwan and removed request for a team May 10, 2022 11:16
@artonge artonge force-pushed the backport/stable22/share_search_tweaks branch 2 times, most recently from 9a346be to e4e12a9 Compare May 11, 2022 13:15
@artonge artonge requested a review from a team May 16, 2022 10:14
@blizzz
Copy link
Member

blizzz commented May 16, 2022

@artonge conflicts

@blizzz blizzz mentioned this pull request May 16, 2022
Merged
@artonge artonge force-pushed the backport/stable22/share_search_tweaks branch 2 times, most recently from 9df783e to aa5d442 Compare May 16, 2022 13:50
@blizzz
Copy link
Member

blizzz commented May 16, 2022

moving to 23.0.6 for lack of reviews

@artonge

This comment was marked as duplicate.

Sign in to view
@nextcloud-command nextcloud-command force-pushed the backport/stable22/share_search_tweaks branch from aa5d442 to 4f74f3d Compare May 31, 2022 09:49
@artonge
Copy link
Contributor Author

artonge commented May 31, 2022

Review ping :)

@artonge
Copy link
Contributor Author

artonge commented Jun 7, 2022

/rebase

artonge added 3 commits June 7, 2022 11:37
@artonge
Add settings to not match userID during full match
839046a 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Tweak tests to include shareapi_restrict_user_enumeration_full_match_…
841f83b 
…userid

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Add settings to ignore second display name in search
e297e1c 
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge added 3 commits June 7, 2022 11:37
@artonge
Add setting to ignore email during search
d0bfca5 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Use share setting in DAV search
77f7855 
shareapi_restrict_user_enumeration_full_match_ignore_second_display_name was introduced to ignore second display name during search from the share panel. But this setting was not respected by search from the calendar application. This fix it.

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge
Use email settings in DAV search
cb66d11 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@nextcloud-command nextcloud-command force-pushed the backport/stable22/share_search_tweaks branch from 4f74f3d to cb66d11 Compare June 7, 2022 11:37
This was referenced Jun 7, 2022
Closed
Closed
Closed
Closed
Merged
@blizzz
Copy link
Member

blizzz commented Jun 13, 2022

moving to 23.0.7

@blizzz blizzz mentioned this pull request Jun 17, 2022
Closed
4 tasks
@artonge artonge merged commit 6644b17 into stable23 Jun 23, 2022
@artonge artonge deleted the backport/stable22/share_search_tweaks branch June 23, 2022 15:35
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 23, 2022
Merged
artonge added a commit that referenced this pull request Jun 27, 2022
@artonge
FInish backport to stable22 of #32322
056ccc6 
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge added a commit that referenced this pull request Jun 27, 2022
@artonge
FInish backport to stable22 of #32322
4e3f95a 
Signed-off-by: Louis Chemineau <louis@chmn.me>
nextcloud-command pushed a commit that referenced this pull request Jun 28, 2022
@artonge
FInish backport to stable22 of #32322
54b0381 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@skjnldsv skjnldsv mentioned this pull request Jul 5, 2022
Merged
13 tasks
artonge added a commit that referenced this pull request Jul 7, 2022
@artonge
FInish backport to stable22 of #32322
7a454a7 
Signed-off-by: Louis Chemineau <louis@chmn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews feature: search feature: sharing
Projects
None yet
Milestone
Nextcloud 23.0.7
Development

Successfully merging this pull request may close these issues.
3 participants
@artonge @blizzz @CarlSchwan