-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide log statements for SCSS cache #23490
Merged
MorrisJobke
merged 1 commit into
master
from
debug/noid/log-statements-for-scss-locking
Oct 16, 2020
Merged
Provide log statements for SCSS cache #23490
MorrisJobke
merged 1 commit into
master
from
debug/noid/log-statements-for-scss-locking
Oct 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
This was referenced Oct 15, 2020
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 34197: failuremariadb10.1-php7.3
|
skjnldsv
approved these changes
Oct 16, 2020
ChristophWurst
approved these changes
Oct 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent
juliusknorr
approved these changes
Oct 16, 2020
Okay - let's get this in and backport it. Then we can maybe finally find the issues that happen around this. |
/backport to stable20 |
/backport to stable19 |
/backport to stable18 |
This was referenced Oct 16, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the debugging session around the SCSS cache. I wonder if we should include this in the normal release so that the behavior could be easily analyzed or if we should just have it on an instance that should be debugged and then fix those issues.
At least the refined logs I would keep.
Part of a series: #23488 and #23478