Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCSSCacher - Lock should not be removed #23488

Merged
merged 1 commit into from
Oct 16, 2020
Merged

SCSSCacher - Lock should not be removed #23488

merged 1 commit into from
Oct 16, 2020

Conversation

MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Oct 15, 2020 •
edited
Loading

This is within the failed lock acquiring branch. So the lock is free by another process and should not be removed because the cached file (that was created by the process having the lock) appeared on the filesystem.

This is part of multiple PRs. I just split them into their smallest independent parts. Other parts: #23478 #23490

@MorrisJobke MorrisJobke added this to the Nextcloud 21 milestone Oct 15, 2020
@MorrisJobke
Copy link
Member Author

/backport to stable20

@MorrisJobke
Copy link
Member Author

/backport to stable19

@MorrisJobke
Copy link
Member Author

/backport to stable18

@MorrisJobke MorrisJobke mentioned this pull request Oct 15, 2020
Merged
@MorrisJobke MorrisJobke requested a review from skjnldsv October 15, 2020 22:01
@MorrisJobke MorrisJobke mentioned this pull request Oct 15, 2020
Merged
ChristophWurst
ChristophWurst approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit unsure if this is right, can't quite wrap my head around it but I'd say worth a try on an effected production instance

@MorrisJobke
SCSSCacher - Lock should not be removed
9273436 
This is within the failed lock acquiring branch. So the lock is free by another process and should not be removed because the cached file (that was created by the process having the lock) appeared on the filesystem.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke force-pushed the fix/noid/no-lock-removal-scss-cacher branch from 266a00c to 9273436 Compare October 16, 2020 08:02
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 16, 2020
@MorrisJobke
Copy link
Member Author

Rebased to fix the conflict with #23490

@MorrisJobke MorrisJobke mentioned this pull request Oct 16, 2020
Closed
@MorrisJobke MorrisJobke merged commit 1c68a6d into master Oct 16, 2020
@MorrisJobke MorrisJobke deleted the fix/noid/no-lock-removal-scss-cacher branch October 16, 2020 11:25
This was referenced Oct 16, 2020
Merged
Merged
Merged
@juliusknorr juliusknorr mentioned this pull request Nov 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@kesselb kesselb Awaiting requested review from kesselb

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug technical debt
Projects
None yet
Milestone
Nextcloud 21
Development

Successfully merging this pull request may close these issues.
4 participants
@MorrisJobke @ChristophWurst @juliusknorr @skjnldsv